From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, Sander.Vanleeuwen@sun.com,
kraxel@redhat.com, anthony@codemonkey.ws, zach@vmware.com
Subject: Re: [PATCH] [RFC] Activate VMX on demand
Date: Tue, 04 Nov 2008 15:37:38 +0200 [thread overview]
Message-ID: <49105022.6050207@redhat.com> (raw)
In-Reply-To: <E7DDCDF2-A810-4C9C-9F08-936599257BBA@suse.de>
Alexander Graf wrote:
>>
>> This should be done in x86.c and made to apply to svm as well. Other
>> VMMs would use efer.svme as an indication that svm is in use, similar
>> to cr4.vmxe today.
>
> Right, that sounds good. So just track the usage counter in x86.c and
> then split the hardware_{en,dis}able functions?
What's there to split in hardware_enable()?
> Or do you want to actually call hardware_{en,dis}able on the usage
> counter events?
Yes.
> There is no real need to enable/disable everything just because of the
> usage counter.
All it does is enable the feature, enable vmxe, and vmxon. I don't
think we gain anything by splitting it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-04 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 16:19 [PATCH] [RFC] Activate VMX on demand Alexander Graf
2008-11-04 10:36 ` Avi Kivity
2008-11-04 13:13 ` Alexander Graf
2008-11-04 13:37 ` Avi Kivity [this message]
2008-11-04 13:44 ` Alexander Graf
2008-11-04 14:38 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49105022.6050207@redhat.com \
--to=avi@redhat.com \
--cc=Sander.Vanleeuwen@sun.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.