All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcupdate: move synchronize_sched() back to rcupdate.c
Date: Wed, 05 Nov 2008 09:51:20 +0800	[thread overview]
Message-ID: <4910FC18.50305@cn.fujitsu.com> (raw)
In-Reply-To: <20081104091556.GG23790@elte.hu>

Ingo Molnar wrote:
> * Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
>> this fix will increase about several hundred bytes to the kernel 
>> text for rcuclassic.
> 
> hm, why is that, and is it true for the full vmlinux as well, for a 
> reasonably large .config?
> 
> Do you get the size increase even if these two are enabled:
> 
>  CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>  CONFIG_OPTIMIZE_INLINING=y
> 
> ?

almost the same, a half of bytes added to kernel text is from this line:
EXPORT_SYMBOL_GPL(synchronize_sched);

> 
> i'd expect the opposite or same-size: given that an ugly 
> quasi-inlining macro is replaced with a shared, out of line function.
> 
> 	Ingo
> 
> 
> 




      reply	other threads:[~2008-11-05  1:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  8:25 [PATCH] rcupdate: move synchronize_sched() back to rcupdate.c Lai Jiangshan
2008-11-04  9:15 ` Ingo Molnar
2008-11-05  1:51   ` Lai Jiangshan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4910FC18.50305@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.