From: Li Zefan <lizf@cn.fujitsu.com>
To: bharata@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Add hierarchical accounting to cpu accounting controller
Date: Wed, 05 Nov 2008 14:17:37 +0800 [thread overview]
Message-ID: <49113A81.60809@cn.fujitsu.com> (raw)
In-Reply-To: <20081104124937.GB4898@in.ibm.com>
> +The CPU accounting controller is used to group tasks using cgroups and
> +account the CPU usage of these group of tasks.
this group or these groups?
...
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9236,6 +9236,7 @@ struct cpuacct {
> struct cgroup_subsys_state css;
> /* cpuusage holds pointer to a u64-type object on every cpu */
> u64 *cpuusage;
> + struct cpuacct *parent;
> };
>
Maybe the comment needs to be updated?
/* track cpu usage of a group of tasks */
struct cpuacct {
...
};
->
/* track cpu usage of a group of tasks and its child groups */
next prev parent reply other threads:[~2008-11-05 6:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 5:43 [PATCH] Add hierarchical accounting to cpu accounting controller Bharata B Rao
2008-10-23 6:41 ` Bharata B Rao
2008-10-23 15:49 ` Paul Menage
2008-10-24 5:08 ` Bharata B Rao
2008-10-24 17:37 ` Paul Menage
2008-10-25 6:01 ` Bharata B Rao
2008-10-25 15:38 ` Paul Menage
2008-10-27 1:17 ` KAMEZAWA Hiroyuki
2008-10-27 4:43 ` Bharata B Rao
2008-10-27 6:57 ` Balbir Singh
2008-10-27 8:25 ` Li Zefan
2008-10-30 17:16 ` Dhaval Giani
2008-10-31 0:40 ` KAMEZAWA Hiroyuki
2008-11-04 12:49 ` Bharata B Rao
2008-11-04 17:20 ` Randy Dunlap
2008-11-05 3:24 ` Bharata B Rao
2008-11-05 3:29 ` Srivatsa Vaddagiri
2008-11-10 10:21 ` Dhaval Giani
2008-11-10 13:09 ` Ingo Molnar
2008-11-10 15:11 ` Bharata B Rao
2008-11-11 11:13 ` Ingo Molnar
2008-11-05 6:17 ` Li Zefan [this message]
2008-11-06 6:43 ` Balbir Singh
2008-11-10 10:22 ` Peter Zijlstra
2008-11-10 13:05 ` Balbir Singh
2008-11-05 3:31 ` Li Zefan
2008-11-05 3:48 ` KAMEZAWA Hiroyuki
2008-10-27 5:54 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49113A81.60809@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.