All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, kraxel@redhat.com, anthony@codemonkey.ws,
	Sander.Vanleeuwen@sun.com, zach@vmware.com, brogers@novell.com
Subject: Re: [PATCH] Activate Virtualization On Demand v2
Date: Wed, 05 Nov 2008 15:12:29 +0200	[thread overview]
Message-ID: <49119BBD.9080106@redhat.com> (raw)
In-Reply-To: <200811051406.34227.borntraeger@de.ibm.com>

Christian Borntraeger wrote:
> When you are at it, could move these printk to the arches that atually 
> enable/disable virtualization?
>
> For example you could do something like 
> if (callback) {
> 	printk "...";
> 	callback();
> }
>
> And then you could remove kvm_arch_hardware_enable/disable from s390 and 
> powerpc.
>
> Havng these messages on s390 and powerpc makes absolutely no sense.
>   

In a separate patch, this is big enough already.

We could do this using kconfig

config KVM_NEEDS_HARDWARE_DETECT
    bool
    default n

and override it for x86/ia64.  This would remove the need to implement 
dummy callbacks in s390/ppc.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-11-05 13:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05  8:48 [PATCH] Activate Virtualization On Demand v2 Alexander Graf
2008-11-05 10:06 ` Avi Kivity
2008-11-05 10:28   ` Alexander Graf
2008-11-05 10:45     ` Avi Kivity
2008-11-05 10:53       ` Alexander Graf
2008-11-05 11:23       ` Alexander Graf
2008-11-05 10:45 ` Zhang, Xiantao
2008-11-05 10:54   ` Alexander Graf
2008-11-05 10:58 ` Daniel P. Berrange
2008-11-05 11:01   ` Alexander Graf
2008-11-05 13:06 ` Christian Borntraeger
2008-11-05 13:12   ` Avi Kivity [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-06-15 11:30 Alexander Graf
2009-06-15 12:17 ` Christoph Hellwig
2009-06-15 12:25   ` Alexander Graf
2009-06-15 12:27     ` Christoph Hellwig
2009-06-16 14:02   ` Avi Kivity
2009-06-16 14:01 ` Avi Kivity
2009-06-16 14:08   ` Alexander Graf
2009-06-16 15:13     ` Avi Kivity
2009-06-17 21:56       ` Alexander Graf
2009-06-18  8:35         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49119BBD.9080106@redhat.com \
    --to=avi@redhat.com \
    --cc=Sander.Vanleeuwen@sun.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=borntraeger@de.ibm.com \
    --cc=brogers@novell.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.