From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 05 Nov 2008 15:24:20 -0800
Subject: [U-Boot] [patch V2] U-Boot Firetux board support
In-Reply-To: <20081105124811.50f8ad76@mangold.emlix.com>
References: <20081105124811.50f8ad76@mangold.emlix.com>
Message-ID: <49122B24.9050206@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Juergen,

Juergen Schoew wrote:
> Hi U-Boot mailling list,
>
> This patchset adds a new ARM board with the NXP PNX8181 cpu to u-boot.
> The PNX8181 is an ARM926ej with an internal DSP (mostly used for Audio
> processing and VOIP codecs) and a baseband processor (used for DECT). The
> chip also features dual ethernet, digital to analog interface, spi, i2c and
> other SOC peripherals.
>
> These boards have been build by NXP Semiconductors GmbH, Nuremberg, Germany
> and are now build by DSPG Technologies GmbH, Nuremberg, Germany.
>
>
> Signed-off-by: J?rgen Sch?w <js@emlix.com>
> Signed-off-by: Sebastian Hess <sh@emlix.com>
> Signed-off-by: Matthias Mwenzel <nxp@mazzoo.de>
> Signed-off-by: Dirk H?rner <dirk.hoerner@dspg.com>
> Signed-off-by: Andreas Wei?el <andreas.weissel@dspg.com>
> ---
>
> Here is the next round of the patch. Thanks for the comments so far. I tried
> to change the code to meet your requirements. Following changes have been
> done:
>
>  - use writex/readx for register accesses
>  - use pointer in readx/writex
>  - whitespace fixes (use tabs)
>  - add Maintainer field
>  - adjust comments to common style
>  - use conditional settings
>  - relocate.S bug fixes
>  - network reworks
>
> I did not move the ethernet driver to drivers/net/ because a lot of hardware
> dependencies are in that driver to work. This IP-Core is not used very often
> by NXP processors (I don't have numbers) so it may not need to be moved. This
> driver does not not use the a struct to save the parameters as suggested
> from Jean-Christophe PLAGNIOL-VILLARD. Sorry but time was too short to fix it
> right now.
>
>   
Here are the expectations for new network drivers:
1. Driver will be in driver/net.  You're not the first with hardware 
dependencies, and there are standard ways of dealing with them.
2. You must use the CONFIG_NET_MULTI-style API, where the driver is 
registered and access functions such as send, halt, recv etc. are called 
through a struct.
3. Driver is initialized through cpu_eth_init() or board_eth_init()

Without meeting these, your code will not be accepted.

regards,
Ben