From: Jeff Garzik <jeff@garzik.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 1/6] sfc: Correct address of gPXE boot configuration in EEPROM
Date: Thu, 06 Nov 2008 00:38:25 -0500 [thread overview]
Message-ID: <491282D1.10401@garzik.org> (raw)
In-Reply-To: <4912824F.6030604@pobox.com>
Jeff Garzik wrote:
> Ben Hutchings wrote:
>> Due to a hardware bug, the originally assigned range cannot reliably
>> be used for boot configuration and must not be modifiable through
>> ethtool.
>>
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>> ---
>> drivers/net/sfc/ethtool.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c
>> index fa98af5..cd0d087 100644
>> --- a/drivers/net/sfc/ethtool.c
>> +++ b/drivers/net/sfc/ethtool.c
>> @@ -174,8 +174,8 @@ static struct efx_ethtool_stat efx_ethtool_stats[]
>> = {
>>
>> /* EEPROM range with gPXE configuration */
>> #define EFX_ETHTOOL_EEPROM_MAGIC 0xEFAB
>> -#define EFX_ETHTOOL_EEPROM_MIN 0x100U
>> -#define EFX_ETHTOOL_EEPROM_MAX 0x400U
>> +#define EFX_ETHTOOL_EEPROM_MIN 0x800U
>> +#define EFX_ETHTOOL_EEPROM_MAX 0x1800U
>
> this seems like something for 2.6.28-rc not 2.6.29, so why wait for 2.6.29?
nevermind, I see the other patch now...
next prev parent reply other threads:[~2008-11-06 5:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 20:31 [PATCH 0/6] sfc: Changes for 2.6.29 Ben Hutchings
2008-11-04 20:32 ` [PATCH 1/6] sfc: Correct address of gPXE boot configuration in EEPROM Ben Hutchings
2008-11-06 5:36 ` Jeff Garzik
2008-11-06 5:38 ` Jeff Garzik [this message]
2008-11-06 5:53 ` Jeff Garzik
2008-11-04 20:33 ` [PATCH 2/6] sfc: Clean up non-volatile memory partitioning Ben Hutchings
2008-11-04 20:34 ` [PATCH 3/6] sfc: Expose flash region storing boot code as MTD Ben Hutchings
2008-11-04 20:34 ` Ben Hutchings
2008-11-04 20:34 ` [PATCH 4/6] sfc: Use lm87 and lm90 drivers for board temperature/power monitoring Ben Hutchings
2008-11-04 20:35 ` [PATCH 5/6] sfc: Do not reset when hardware monitor detects a fault Ben Hutchings
2008-11-04 20:36 ` [PATCH 6/6] sfc: Add driverlink API to support virtual NIC drivers Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491282D1.10401@garzik.org \
--to=jeff@garzik.org \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.