From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1Ky1Q6-0006qd-Vm for kexec@lists.infradead.org; Thu, 06 Nov 2008 09:44:55 +0000 Message-ID: <4912BC86.8050607@redhat.com> Date: Thu, 06 Nov 2008 11:44:38 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-16-git-send-email-ehabkost@redhat.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Eric W. Biederman" Cc: Andrew Morton , Eduardo Habkost , kvm@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Ingo Molnar , Andrey Borzenkov , mingo@redhat.com, Vivek Goyal Eric W. Biederman wrote: >> >> + r = set_virt_disable_func(crash_hardware_disable); >> > > Can we make this say: > set_virt_disable_func(kvm_x86_ops->crash_hardware_disable); > > So we can avoid going through 2 levels of function pointers? > I find that a little scary in code that might be running > at the edge of stack overflow. > Actually, with scheduling disabled we can overflow the stack as much as we like. It will reduce the quality of the dump, but everything ought to work. -- error compiling committee.c: too many arguments to function _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025AbYKFJpg (ORCPT ); Thu, 6 Nov 2008 04:45:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753325AbYKFJpY (ORCPT ); Thu, 6 Nov 2008 04:45:24 -0500 Received: from mx2.redhat.com ([66.187.237.31]:53967 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbYKFJpW (ORCPT ); Thu, 6 Nov 2008 04:45:22 -0500 Message-ID: <4912BC86.8050607@redhat.com> Date: Thu, 06 Nov 2008 11:44:38 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Eduardo Habkost , Ingo Molnar , Simon Horman , Andrew Morton , Vivek Goyal , Haren Myneni , Andrey Borzenkov , mingo@redhat.com, "Rafael J. Wysocki" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-16-git-send-email-ehabkost@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: >> >> + r = set_virt_disable_func(crash_hardware_disable); >> > > Can we make this say: > set_virt_disable_func(kvm_x86_ops->crash_hardware_disable); > > So we can avoid going through 2 levels of function pointers? > I find that a little scary in code that might be running > at the edge of stack overflow. > Actually, with scheduling disabled we can overflow the stack as much as we like. It will reduce the quality of the dump, but everything ought to work. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization Date: Thu, 06 Nov 2008 11:44:38 +0200 Message-ID: <4912BC86.8050607@redhat.com> References: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> <1225810364-8990-16-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Eduardo Habkost , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Haren Myneni , Simon Horman , Ingo Molnar , Andrey Borzenkov , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Vivek Goyal To: "Eric W. Biederman" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org Eric W. Biederman wrote: >> >> + r = set_virt_disable_func(crash_hardware_disable); >> > > Can we make this say: > set_virt_disable_func(kvm_x86_ops->crash_hardware_disable); > > So we can avoid going through 2 levels of function pointers? > I find that a little scary in code that might be running > at the edge of stack overflow. > Actually, with scheduling disabled we can overflow the stack as much as we like. It will reduce the quality of the dump, but everything ought to work. -- error compiling committee.c: too many arguments to function