From: Avi Kivity <avi@redhat.com>
To: "Daniel Godás" <dgodas@gmail.com>
Cc: KVM List <kvm@vger.kernel.org>
Subject: Re: KVM_CAP_DEVICE_ASSIGNMENT should depend on CONFIG_PCI
Date: Thu, 06 Nov 2008 18:13:01 +0200 [thread overview]
Message-ID: <4913178D.8010008@redhat.com> (raw)
In-Reply-To: <e4de053b0811021454y2084e79cq6c666fa9cb04776f@mail.gmail.com>
Daniel Godás wrote:
> Hello,
>
> if you compile the kernel with KVM activated and without PCI support
> you get the following crash:
>
> CC arch/x86/kvm/../../../virt/kvm/kvm_main.o
> arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function
> 'kvm_free_assigned_device':
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:155: error: implicit
> declaration of function 'pci_reset_function'
> make[1]: *** [arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1
> make: *** [arch/x86/kvm] Error 2
>
> This can be reproduced by using the attached config file. Obviously
> the pci_reset_function should not be called when PCI support is
> disabled. These changes fix the issue:
>
I made KVM/x86 depend on PCI. If someone wants to run kvm on a non-pci
x86 host, we (they) can refactor it.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-11-06 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 22:54 KVM_CAP_DEVICE_ASSIGNMENT should depend on CONFIG_PCI Daniel Godás
2008-11-06 16:13 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4913178D.8010008@redhat.com \
--to=avi@redhat.com \
--cc=dgodas@gmail.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.