From: Steven Rostedt <srostedt@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@redhat.com
Subject: Re: next-20081106: today's ftrace episode
Date: Thu, 06 Nov 2008 15:03:26 -0500 [thread overview]
Message-ID: <49134D8E.1070407@redhat.com> (raw)
In-Reply-To: <20081106194432.GA17188@x200.localdomain>
Alexey Dobriyan wrote:
> On m68k-amiga:
>
> CC arch/m68k/kernel/asm-offsets.s
> In file included from include/linux/fs.h:287,
> from include/linux/ftrace.h:5, <===
> from include/linux/hardirq.h:7,
> from include2/asm/system.h:69,
> from include/linux/list.h:7, <===
> from include/linux/preempt.h:11,
> from include/linux/spinlock.h:50,
> from include/linux/seqlock.h:29,
> from include/linux/time.h:8,
> from include/linux/timex.h:57,
> from include/linux/sched.h:54,
> from arch/m68k/kernel/asm-offsets.c:12:
> include/linux/wait.h:37: error: field 'task_list' has incomplete type
> ...
>
> commit 7e5e26a3d8ac4bcadb380073dc9604c07a9a6198 aka "trace: fix hardirq header for non ftrace archs"
>
>
>
We only need to include the ftrace.h to declare the ftrace_nmi_enter and
exit.
I could separate that out into its own "ftrace_irq.h" file, that
hardirq.h can include. That should fix it.
basically all that would be needed in that file is this:
#ifdef CONFIG_DYNAMIC_FTRACE
extern void ftrace_nmi_enter(void);
extern void ftrace_nmi_exit(void);
#else
static inline void ftrace_nmi_enter(void) { }
static inline void ftrace_nmi_exit(void) { }
#endif /* CONFIG_DYNAMIC_FTRACE */
-- Steve
next prev parent reply other threads:[~2008-11-06 20:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 6:36 linux-next: Tree for November 6 Stephen Rothwell
2008-11-06 18:39 ` next-20081106: undefined reference to `__per_cpu_start' Alexey Dobriyan
2008-11-06 19:15 ` Christoph Lameter
2008-11-06 22:34 ` Alexey Dobriyan
2008-11-07 18:32 ` Christoph Lameter
2008-11-07 5:21 ` Stephen Rothwell
2008-11-07 5:44 ` Alexey Dobriyan
2008-11-07 18:28 ` Christoph Lameter
2008-11-07 18:40 ` Christoph Lameter
2008-11-18 4:33 ` linux-next: cpu_alloc tree patch (Was: Re: next-20081106: undefined reference to `__per_cpu_start') Stephen Rothwell
2008-11-19 19:18 ` Christoph Lameter
2008-11-12 7:59 ` next-20081106: undefined reference to `__per_cpu_start' Geert Uytterhoeven
2008-11-12 11:18 ` Mike Frysinger
2008-11-06 18:54 ` next-20081106: perfmon on ia64 Alexey Dobriyan
2008-11-06 20:44 ` stephane eranian
2008-11-06 19:44 ` next-20081106: today's ftrace episode Alexey Dobriyan
2008-11-06 20:03 ` Steven Rostedt [this message]
2008-11-06 20:15 ` Alexey Dobriyan
2008-11-06 20:28 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49134D8E.1070407@redhat.com \
--to=srostedt@redhat.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.