From: Li Zefan <lizf@cn.fujitsu.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
Date: Sat, 08 Nov 2008 17:39:17 +0800 [thread overview]
Message-ID: <49155E45.3030704@cn.fujitsu.com> (raw)
In-Reply-To: <20081108091113.32236.12390.sendpatchset@localhost.localdomain>
> +static int mem_cgroup_hierarchy_write(struct cgroup *cont, struct cftype *cft,
> + u64 val)
> +{
> + int retval = 0;
> + struct mem_cgroup *mem = mem_cgroup_from_cont(cont);
> +
> + if (val == 1) {
> + if (list_empty(&cont->children))
cgroup_lock should be held before checking cont->children.
> + mem->use_hierarchy = val;
> + else
> + retval = -EBUSY;
> + } else if (val == 0) {
And code duplicate.
> + if (list_empty(&cont->children))
> + mem->use_hierarchy = val;
> + else
> + retval = -EBUSY;
> + } else
> + retval = -EINVAL;
> +
> + return retval;
> +}
> +
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
Date: Sat, 08 Nov 2008 17:39:17 +0800 [thread overview]
Message-ID: <49155E45.3030704@cn.fujitsu.com> (raw)
In-Reply-To: <20081108091113.32236.12390.sendpatchset@localhost.localdomain>
> +static int mem_cgroup_hierarchy_write(struct cgroup *cont, struct cftype *cft,
> + u64 val)
> +{
> + int retval = 0;
> + struct mem_cgroup *mem = mem_cgroup_from_cont(cont);
> +
> + if (val == 1) {
> + if (list_empty(&cont->children))
cgroup_lock should be held before checking cont->children.
> + mem->use_hierarchy = val;
> + else
> + retval = -EBUSY;
> + } else if (val == 0) {
And code duplicate.
> + if (list_empty(&cont->children))
> + mem->use_hierarchy = val;
> + else
> + retval = -EBUSY;
> + } else
> + retval = -EINVAL;
> +
> + return retval;
> +}
> +
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-08 9:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 9:10 [RFC][mm][PATCH 0/4] Memory cgroup hierarchy introduction (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-08 9:10 ` [RFC][mm] [PATCH 1/4] Memory cgroup hierarchy documentation (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-08 9:10 ` [RFC][mm] [PATCH 2/4] Memory cgroup resource counters for hierarchy (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-11 3:04 ` KAMEZAWA Hiroyuki
2008-11-11 3:04 ` KAMEZAWA Hiroyuki
2008-11-11 4:52 ` Balbir Singh
2008-11-11 4:52 ` Balbir Singh
2008-11-08 9:11 ` [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v2) Balbir Singh
2008-11-08 9:11 ` Balbir Singh
2008-11-11 3:06 ` KAMEZAWA Hiroyuki
2008-11-11 3:06 ` KAMEZAWA Hiroyuki
2008-11-11 4:47 ` Balbir Singh
2008-11-11 4:47 ` Balbir Singh
2008-11-11 5:01 ` KAMEZAWA Hiroyuki
2008-11-11 5:01 ` KAMEZAWA Hiroyuki
2008-11-11 6:24 ` Balbir Singh
2008-11-11 6:24 ` Balbir Singh
2008-11-08 9:11 ` [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2) Balbir Singh
2008-11-08 9:11 ` Balbir Singh
2008-11-08 9:39 ` Li Zefan [this message]
2008-11-08 9:39 ` Li Zefan
2008-11-08 9:49 ` Balbir Singh
2008-11-08 9:49 ` Balbir Singh
2008-11-11 3:10 ` KAMEZAWA Hiroyuki
2008-11-11 3:10 ` KAMEZAWA Hiroyuki
2008-11-11 5:01 ` Balbir Singh
2008-11-11 5:01 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49155E45.3030704@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.