All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Zhuravlev <Alex.Zhuravlev@Sun.COM>
To: Andreas Dilger <adilger@Sun.COM>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC] ext4: Remove i_ext_generation from	ext4_inode_info structure
Date: Sat, 08 Nov 2008 13:07:44 +0300	[thread overview]
Message-ID: <491564F0.4030502@sun.com> (raw)
In-Reply-To: <20081108085928.GK3184@webber.adilger.int>

Andreas Dilger wrote:
> On Nov 04, 2008  18:47 -0500, Theodore Ts'o wrote:
>> ext4_inode_info.i_ext_generation isn't used by anything.  Was there an
>> intent to use it for something in the future?
> 
> Alex was going to use this at one point in the future, but it never
> happened.

actually it was used by delayed allocation patch as walk_space() takes
truncate_sem, then, if block isn't allocated yet, start transaction which
we can't do holding truncate_sem. so the idea is to release truncate_sem,
start transaction, then acquire truncate_sem. but in this window the tree
can change making path structure obsolete. either we check tree hasn't
changed or use generation to avoid unneeded path revalidation?

thanks, Alex




      reply	other threads:[~2008-11-08 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 23:47 [PATCH, RFC] ext4: Remove i_ext_generation from ext4_inode_info structure Theodore Ts'o
2008-11-08  8:59 ` Andreas Dilger
2008-11-08 10:07   ` Alex Zhuravlev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491564F0.4030502@sun.com \
    --to=alex.zhuravlev@sun.com \
    --cc=adilger@Sun.COM \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.