From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kymqe-0000vQ-6B for mharc-grub-devel@gnu.org; Sat, 08 Nov 2008 07:23:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kymqd-0000vL-5f for grub-devel@gnu.org; Sat, 08 Nov 2008 07:23:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kymqa-0000r0-Ez for grub-devel@gnu.org; Sat, 08 Nov 2008 07:23:25 -0500 Received: from [199.232.76.173] (port=44442 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kymqa-0000qr-9b for grub-devel@gnu.org; Sat, 08 Nov 2008 07:23:24 -0500 Received: from mta-out.inet.fi ([195.156.147.13]:58441 helo=kirsi2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KymqZ-0001GT-W8 for grub-devel@gnu.org; Sat, 08 Nov 2008 07:23:24 -0500 Received: from [127.0.0.1] (84.248.105.254) by kirsi2.inet.fi (8.5.014) id 48FC5B8900FD3A5B for grub-devel@gnu.org; Sat, 8 Nov 2008 14:23:22 +0200 Message-ID: <491584C4.5020407@nic.fi> Date: Sat, 08 Nov 2008 14:23:32 +0200 From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: The development of GRUB 2 References: <20081105095850.GB12677@thorin> <20081106150212.GC24460@thorin> <20081106160641.GA26883@thorin> <20081107160725.GD17223@xolotl.n0ano.com> <49147245.6080105@nic.fi> <20081108112536.GA11583@thorin> In-Reply-To: <20081108112536.GA11583@thorin> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: Quoted-Printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] PCI serial card support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2008 12:23:27 -0000 Robert Millan wrote: > On Fri, Nov 07, 2008 at 06:52:21PM +0200, Vesa J=C3=A4=C3=A4skel=C3=A4i= nen wrote: >> n0ano@n0ano.com wrote: >>> Bad news, I heard back from the two people who wrote the PCI serial >>> code for Linux (Russell King & Ted Tso) and they both agree that, >>> no matter how the ambiguity got into the Linux source files, their >>> intent was that the code was GPL v2 only. >>> >>> That being the case, we can't use the code and I don't want to try >>> and re-write it from scratch so we're back to having the user manuall= y >>> specify the I/O port address but at least I can create a PCI ID table >>> to map the base baud. >> Ok. Then I would suggest that only simple change is made at this time = to >> support it. So we start from scratch on that implementation. Anyway... >> it can be improved later on. >=20 > Why not use PCI ID to support this particular card? This way Donald do= esn't > have to support all cards, but the base is laid out so more cards can b= e added > in the future. I have nothing against that. But in any case I think there has to be this override functionality support. Just make it a bit harder for user to type so they know it is advanced feature :). Making these transparent for user is always a plus. I just feel that it might be a bit overkill to chain this module to pci module. Of course you can dynamically check if PCI module is there and then ask identification information from there. If you make it other way around so that some other module references to serial module and then just registers new serial device there then that is better of course. isnmod pciserial [device location in system, or if omitted, autodetect]?