All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	david.marchand@redhat.com, jerinjacobk@gmail.com,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
Date: Fri, 28 Jul 2023 17:42:11 +0200	[thread overview]
Message-ID: <4916019.0VBMTVartN@thomas> (raw)
In-Reply-To: <9837e5a0-f76d-f126-32de-193dd9e97cde@amd.com>

25/07/2023 10:40, Ferruh Yigit:
> On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > Deprecation notice to add "rte_eventdev_port_data" field to
> > ``rte_event_fp_ops`` for callback support.
> > 
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index fb771a0305..057f97ce5a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,6 +130,13 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >  
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +  rte_eventdev_port_data is used to hold callbacks registered optionally
> > +  per event device port and associated callback data. By adding rte_eventdev_port_data
> > +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> > +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> > +
> >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> >    as these are internal to DPDK library and drivers.
> >  
> 
> +techboard,
> 
> Request for review/ack, patch is to extend eventdev to support callbacks
> per packet.


It does not look necessary to announce adding new fields.
The ABI compatibility breakage should be covered by this patch:
https://patches.dpdk.org/project/dpdk/patch/20230728152052.1204486-1-thomas@monjalon.net/

Marking as superseded.



      parent reply	other threads:[~2023-07-28 15:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 17:30 [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops Sivaprasad Tummala
2023-07-13  8:51 ` Jerin Jacob
2023-07-13 10:38   ` Tummala, Sivaprasad
2023-07-13 10:40     ` Jerin Jacob
2023-07-14 11:32       ` Tummala, Sivaprasad
2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
2023-07-17 11:43   ` Jerin Jacob
2023-07-17 12:42     ` Ferruh Yigit
2023-07-25  8:40   ` Ferruh Yigit
2023-07-25 16:46     ` Hemant Agrawal
2023-07-25 18:44       ` Pavan Nikhilesh Bhagavatula
2023-07-28 15:42     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4916019.0VBMTVartN@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jerinjacobk@gmail.com \
    --cc=sivaprasad.tummala@amd.com \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.