All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Nielsen <a.nielsen@shikadi.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
	netfilter-devel@vger.kernel.org,
	Richard Purdie <rpurdie@openedhand.com>
Subject: Re: [PATCH 2/2] New netfilter target to trigger LED devices
Date: Mon, 10 Nov 2008 07:44:03 +1000	[thread overview]
Message-ID: <491759A3.1010209@shikadi.net> (raw)
In-Reply-To: <20081109175819.GA3127@x200.localdomain>

>>>> +	/*noconst*/struct xt_led_info_internal *ledinternal =
>>>>                        ledinfo->internal_data;
>>> 	  ^^^^^^^
>>> What is this?
>> A C89-style comment?
> 
> I'm talking about noconst. Utterly pointless.

It's to highlight the parts of my code where I'm taking a
const pointer, and then modifying the data pointed to.  I'm
not sure whether this is allowed, so I thought I'd play
it safe and flag that part of the code for comment.

If you think it's fine as is then I'd be happy to remove
the comment, unless it might be helpful to explain to
others that what I'm doing is intentional.

Cheers,
Adam.


      reply	other threads:[~2008-11-09 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-09 13:26 [PATCH 2/2] New netfilter target to trigger LED devices Adam Nielsen
2008-11-09 13:36 ` Jan Engelhardt
2008-11-09 13:42   ` Adam Nielsen
2008-11-09 17:10 ` Alexey Dobriyan
2008-11-09 17:40   ` Jan Engelhardt
2008-11-09 17:58     ` Alexey Dobriyan
2008-11-09 21:44       ` Adam Nielsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491759A3.1010209@shikadi.net \
    --to=a.nielsen@shikadi.net \
    --cc=adobriyan@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rpurdie@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.