All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: Jan Kara <jack@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel
Date: Thu, 05 Sep 2024 16:12:33 +0200	[thread overview]
Message-ID: <4917672.OV4Wx5bFTl@localhost> (raw)
In-Reply-To: <20240904123604.875639-1-pvorel@suse.cz>

Hi,

Reviewed-by: Avinesh Kumar <akumar@suse.de>

On Wednesday, September 4, 2024 2:36:04 PM GMT+2 Petr Vorel wrote:
> Kernel commit e730558adffb ("fsnotify: consistent behavior for parent
> not watching children") will not be backported to SLE15-SP[45] v5.14
> based kernel, therefore skip it for kernel < 5.19 (the original mainline
> kernel which brought the functionality.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/kernel/syscalls/fanotify/fanotify09.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
> index 48b198b941..72e9239897 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify09.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
> @@ -379,7 +379,12 @@ static void test_fanotify(unsigned int n)
>  		return;
>  	}
>  
> -	if (tc->ignore && tst_kvercmp(5, 10, 0) < 0) {
> +	static struct tst_kern_exv kvers[] = {
> +		{"SLES", "5.19"},
> +		{NULL, NULL}
> +	};
> +
> +	if (tc->ignore && tst_kvercmp2(5, 10, 0, kvers) < 0) {
>  		tst_res(TCONF, "ignored mask on parent dir has undefined "
>  				"behavior on kernel < 5.10");
>  		return;
> 

Regards,
Avinesh




-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-09-05 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 12:36 [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel Petr Vorel
2024-09-05 14:12 ` Avinesh Kumar [this message]
2024-09-10  8:46 ` Martin Doucha
  -- strict thread matches above, loose matches on Subject: below --
2024-09-06  7:25 Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4917672.OV4Wx5bFTl@localhost \
    --to=akumar@suse.de \
    --cc=jack@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.