From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: libiptc: remove typedef indirection
Date: Mon, 10 Nov 2008 17:00:00 +0100 [thread overview]
Message-ID: <49185A80.5040108@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0811060933060.26551@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> commit ede2c549d4c8b35cec6b7eb5bbbaf95b40168ab0
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Thu Nov 6 05:35:33 2008 +0100
>
> libiptc: remove typedef indirection
>
> Don't you hate it when iptc_handle_t *x actually is a double-indirection
> struct iptc_handle **? This also shows the broken constness model, since
> "const iptc_handle_t x" = "iptc_handle_t const x" =
> "struct iptc_handle *const x", which is like no const at all.
> Lots of things to do then.
Applied, thanks.
prev parent reply other threads:[~2008-11-10 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 8:34 libiptc: remove typedef indirection Jan Engelhardt
2008-11-06 8:35 ` libiptc: remove indirections Jan Engelhardt
2008-11-06 8:35 ` libiptc: remove unused iptc_get_raw_socket and iptc_check_packet Jan Engelhardt
2008-11-06 8:35 ` libiptc: make sockfd a per-handle thing Jan Engelhardt
2008-11-06 8:35 ` libiptc: use hex output for hookmask Jan Engelhardt
2008-11-10 16:07 ` Patrick McHardy
2008-11-10 16:07 ` libiptc: make sockfd a per-handle thing Patrick McHardy
2008-11-10 16:24 ` Jan Engelhardt
2008-11-10 16:26 ` Patrick McHardy
2008-11-10 16:01 ` libiptc: remove unused iptc_get_raw_socket and iptc_check_packet Patrick McHardy
2008-11-10 16:01 ` libiptc: remove indirections Patrick McHardy
2008-11-10 16:00 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49185A80.5040108@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.