From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: libiptc: make sockfd a per-handle thing
Date: Mon, 10 Nov 2008 17:26:21 +0100
Message-ID: <491860AD.8020408@trash.net>
References: <alpine.LNX.1.10.0811060933060.26551@fbirervta.pbzchgretzou.qr> <alpine.LNX.1.10.0811060934380.26551@fbirervta.pbzchgretzou.qr> <alpine.LNX.1.10.0811060935020.26551@fbirervta.pbzchgretzou.qr> <alpine.LNX.1.10.0811060935130.26551@fbirervta.pbzchgretzou.qr> <49185C33.9090208@trash.net> <alpine.LNX.1.10.0811101722550.22110@fbirervta.pbzchgretzou.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
To: Jan Engelhardt <jengelh@medozas.de>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:52644 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753268AbYKJQ0b (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Mon, 10 Nov 2008 11:26:31 -0500
In-Reply-To: <alpine.LNX.1.10.0811101722550.22110@fbirervta.pbzchgretzou.qr>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Jan Engelhardt wrote:
> On Monday 2008-11-10 17:07, Patrick McHardy wrote:
> 
>> Jan Engelhardt wrote:
>>> commit 976ee346f58ae69ee82fcd750813d2b4fb7379b1
>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>> Date:   Thu Nov 6 09:23:06 2008 +0100
>>>
>>> libiptc: make sockfd a per-handle thing
>> No objections in general, but I would like to see an explanation
>> of the impact the usage-counter removal has on things like
>> iptables-restore, that initialize the socket multiple times.
> 
> None, because iptc_commit closes the socket --
> so that iptables-restore opened the socket once for each table
> anew anyway. (You can look for this with
> `strace -e socket iptables-restore`.)

Thanks for the explanation, applied.