All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
	<linux-kernel@vger.kernel.org>, <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Michael Roth <michael.roth@amd.com>,
	Joerg Roedel <Joerg.Roedel@amd.com>
Subject: Re: [sos-linux-ext-patches] [PATCH] x86/sev: Ensure SVSM reserved fields are initialized to zero
Date: Mon, 18 Aug 2025 11:46:15 +0530	[thread overview]
Message-ID: <4918f481-bbee-4337-870d-e62d8d2d86cf@amd.com> (raw)
In-Reply-To: <7cde412f8b057ea13a646fb166b1ca023f6a5031.1755098819.git.thomas.lendacky@amd.com>



On 8/13/2025 8:56 PM, Tom Lendacky wrote:

> In order to support future versions of the SVSM_CORE_PVALIDATE call,
> all reserved fields within a PVALIDATE entry must be set to zero as an
> SVSM should be ensuring all reserved fields are zero in order to support

Does "an SVSM" mean here an implementation like Coconut SVSM ?

> future usage of reserved areas based on the protocol version.> 
> Fixes: fcd042e86422 ("x86/sev: Perform PVALIDATE using the SVSM when not at VMPL0")
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  arch/x86/boot/startup/sev-shared.c | 1 +
>  arch/x86/coco/sev/core.c           | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/arch/x86/boot/startup/sev-shared.c b/arch/x86/boot/startup/sev-shared.c
> index ac7dfd21ddd4..a34cd19796f9 100644
> --- a/arch/x86/boot/startup/sev-shared.c
> +++ b/arch/x86/boot/startup/sev-shared.c
> @@ -785,6 +785,7 @@ static void __head svsm_pval_4k_page(unsigned long paddr, bool validate)
>  	pc->entry[0].page_size = RMP_PG_SIZE_4K;
>  	pc->entry[0].action    = validate;
>  	pc->entry[0].ignore_cf = 0;
> +	pc->entry[0].rsvd      = 0;
>  	pc->entry[0].pfn       = paddr >> PAGE_SHIFT;
>  
>  	/* Protocol 0, Call ID 1 */
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 400a6ab75d45..14ef5908fb27 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -227,6 +227,7 @@ static u64 svsm_build_ca_from_pfn_range(u64 pfn, u64 pfn_end, bool action,
>  		pe->page_size = RMP_PG_SIZE_4K;
>  		pe->action    = action;
>  		pe->ignore_cf = 0;
> +		pe->rsvd      = 0;
>  		pe->pfn       = pfn;
>  
>  		pe++;
> @@ -257,6 +258,7 @@ static int svsm_build_ca_from_psc_desc(struct snp_psc_desc *desc, unsigned int d
>  		pe->page_size = e->pagesize ? RMP_PG_SIZE_2M : RMP_PG_SIZE_4K;
>  		pe->action    = e->operation == SNP_PAGE_STATE_PRIVATE;
>  		pe->ignore_cf = 0;
> +		pe->rsvd      = 0;
>  		pe->pfn       = e->gfn;
>  
>  		pe++;
> 
> base-commit: 4c699535a3d483562354432a945a035f15dfceeb


  parent reply	other threads:[~2025-08-18  6:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 15:26 [PATCH] x86/sev: Ensure SVSM reserved fields are initialized to zero Tom Lendacky
2025-08-15  6:59 ` Joerg Roedel
2025-08-18  6:16 ` Nikunj A. Dadhania [this message]
2025-08-18 13:47   ` [sos-linux-ext-patches] " Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4918f481-bbee-4337-870d-e62d8d2d86cf@amd.com \
    --to=nikunj@amd.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.