From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
Date: Tue, 11 Nov 2008 10:31:00 +0530 [thread overview]
Message-ID: <4919118C.9060701@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081111121039.91017d3c.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Sat, 08 Nov 2008 14:41:13 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> Don't enable multiple hierarchy support by default. This patch introduces
>> a features element that can be set to enable the nested depth hierarchy
>> feature. This feature can only be enabled when the cgroup for which the
>> feature this is enabled, has no children.
>>
>> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>> ---
>>
> IMHO, permission to this is not enough.
>
> I think following is sane way.
> ==
> When parent->use_hierarchy==1.
> my->use_hierarchy must be "1" and cannot be tunrned to be "0" even if no children.
> When parent->use_hierarchy==0
> my->use_hierarchy can be either of "0" or "1".
> this value can be chagned if we don't have children
> ==
Sounds reasonable, will fix in v3.
--
Balbir
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
Date: Tue, 11 Nov 2008 10:31:00 +0530 [thread overview]
Message-ID: <4919118C.9060701@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081111121039.91017d3c.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Sat, 08 Nov 2008 14:41:13 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> Don't enable multiple hierarchy support by default. This patch introduces
>> a features element that can be set to enable the nested depth hierarchy
>> feature. This feature can only be enabled when the cgroup for which the
>> feature this is enabled, has no children.
>>
>> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>> ---
>>
> IMHO, permission to this is not enough.
>
> I think following is sane way.
> ==
> When parent->use_hierarchy==1.
> my->use_hierarchy must be "1" and cannot be tunrned to be "0" even if no children.
> When parent->use_hierarchy==0
> my->use_hierarchy can be either of "0" or "1".
> this value can be chagned if we don't have children
> ==
Sounds reasonable, will fix in v3.
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-11 5:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 9:10 [RFC][mm][PATCH 0/4] Memory cgroup hierarchy introduction (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-08 9:10 ` [RFC][mm] [PATCH 1/4] Memory cgroup hierarchy documentation (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-08 9:10 ` [RFC][mm] [PATCH 2/4] Memory cgroup resource counters for hierarchy (v2) Balbir Singh
2008-11-08 9:10 ` Balbir Singh
2008-11-11 3:04 ` KAMEZAWA Hiroyuki
2008-11-11 3:04 ` KAMEZAWA Hiroyuki
2008-11-11 4:52 ` Balbir Singh
2008-11-11 4:52 ` Balbir Singh
2008-11-08 9:11 ` [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v2) Balbir Singh
2008-11-08 9:11 ` Balbir Singh
2008-11-11 3:06 ` KAMEZAWA Hiroyuki
2008-11-11 3:06 ` KAMEZAWA Hiroyuki
2008-11-11 4:47 ` Balbir Singh
2008-11-11 4:47 ` Balbir Singh
2008-11-11 5:01 ` KAMEZAWA Hiroyuki
2008-11-11 5:01 ` KAMEZAWA Hiroyuki
2008-11-11 6:24 ` Balbir Singh
2008-11-11 6:24 ` Balbir Singh
2008-11-08 9:11 ` [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2) Balbir Singh
2008-11-08 9:11 ` Balbir Singh
2008-11-08 9:39 ` Li Zefan
2008-11-08 9:39 ` Li Zefan
2008-11-08 9:49 ` Balbir Singh
2008-11-08 9:49 ` Balbir Singh
2008-11-11 3:10 ` KAMEZAWA Hiroyuki
2008-11-11 3:10 ` KAMEZAWA Hiroyuki
2008-11-11 5:01 ` Balbir Singh [this message]
2008-11-11 5:01 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4919118C.9060701@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.