From: "Benoît Monin" <benoit.monin@gmx.fr>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: skip offload for NETIF_F_IPV6_CSUM if ipv6 header contains extension
Date: Tue, 31 Dec 2024 16:24:26 +0100 [thread overview]
Message-ID: <4919277.OV4Wx5bFTl@benoit.monin> (raw)
In-Reply-To: <CANn89iK1hdC3Nt8KPhOtTF8vCPc1AHDCtse_BTNki1pWxAByTQ@mail.gmail.com>
Hi,
23/12/2024 Eric Dumazet wrote:
[...]
>
> FYI, this patch broke BIG TCP over IPv6.
>
> [ 239.698598] Oops skb_network_header_len()=48 skb->len=67210
> [ 239.704122] skb len=67210 headroom=162 headlen=94 tailroom=0
> mac=(162,14) mac_len=0 net=(176,48) trans=224
> shinfo(txflags=0 nr_frags=3 gso(size=1428 type=16 segs=47))
> csum(0x1000e0 start=224 offset=16 ip_summed=3
> complete_sw=0 valid=0 level=0)
> hash(0xadf29e31 sw=0 l4=1) proto=0x86dd pkttype=0 iif=0
> priority=0x18020 mark=0x0 alloc_cpu=46 vlan_all=0x0
> encapsulation=0 inner(proto=0x0000, mac=0, net=0,
> trans=0)\x00, net=0, trans=0)
> [ 239.704153] dev name=eth2 feat=0x0000030000114ab3
> [ 239.704155] sk family=10 type=1 proto=6
[...]
What is the driver of eth2?
Since it was working before the patch, it means that the hardware is able to
deal with variable-sized IP header. So shouldn't its features contains
NETIF_F_HW_CSUM instead of NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM?
--
Benoît
next prev parent reply other threads:[~2024-12-31 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 14:01 [PATCH v2 net] net: skip offload for NETIF_F_IPV6_CSUM if ipv6 header contains extension Benoît Monin
2024-10-25 14:55 ` Willem de Bruijn
2024-12-23 10:40 ` Eric Dumazet
2024-12-31 10:56 ` Willem de Bruijn
2024-12-31 15:24 ` Benoît Monin [this message]
2024-12-31 16:00 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4919277.OV4Wx5bFTl@benoit.monin \
--to=benoit.monin@gmx.fr \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.