From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] e1000e: fix warn_on reload after phy_id error
Date: Tue, 11 Nov 2008 03:31:10 -0500 [thread overview]
Message-ID: <491942CE.4010604@garzik.org> (raw)
In-Reply-To: <20081108002739.17508.60954.stgit@gitlost.lost>
Jeff Kirsher wrote:
> If the driver fails to initialize the first time due to the failure in the
> phy_id check the kernel triggers a warn_on on the second try to load the
> driver because the driver did not free the msi/x resources in the first
> load because of the previous failure in phy_id check.
Is that all one sentence? Can I buy a comma or semi-colon, Pat? :)
More seriously, this description is not very helpful. A good
description precisely outlines the _solution_ ("fix msi/x resource
leak"), perhaps with a bit of concise problem description ("failure to
free msi/x resources").
Your description focuses mostly on what the user/tester experiences and
observes, whereas in a changeset description the most important thing to
communicate is to describe the engineering change to the driver (proper
release of resources).
Jeff
prev parent reply other threads:[~2008-11-11 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 0:27 [PATCH] e1000e: fix warn_on reload after phy_id error Jeff Kirsher
2008-11-11 8:31 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491942CE.4010604@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.