From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3)
Date: Wed, 12 Nov 2008 09:30:43 +0530 [thread overview]
Message-ID: <491A54EB.3020500@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081112125204.a92816cc.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Tue, 11 Nov 2008 18:04:17 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> +
>> + /*
>> + * We need to give up the cgroup lock if it is held, since
>> + * it creates the potential for deadlock. cgroup_mutex should
>> + * be acquired after cpu_hotplug lock. In this path, we
>> + * acquire the cpu_hotplug lock after acquiring the cgroup_mutex
>> + * Giving it up should be OK
>> + */
>> + if (cgroup_locked)
>> + cgroup_unlock();
>
> nice catch. I'll post a fix to this as its own patch.
Sure, feel free to add my signed-off-by on it.
--
Balbir
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3)
Date: Wed, 12 Nov 2008 09:30:43 +0530 [thread overview]
Message-ID: <491A54EB.3020500@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081112125204.a92816cc.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Tue, 11 Nov 2008 18:04:17 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> +
>> + /*
>> + * We need to give up the cgroup lock if it is held, since
>> + * it creates the potential for deadlock. cgroup_mutex should
>> + * be acquired after cpu_hotplug lock. In this path, we
>> + * acquire the cpu_hotplug lock after acquiring the cgroup_mutex
>> + * Giving it up should be OK
>> + */
>> + if (cgroup_locked)
>> + cgroup_unlock();
>
> nice catch. I'll post a fix to this as its own patch.
Sure, feel free to add my signed-off-by on it.
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-12 4:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 12:33 [RFC][mm][PATCH 0/4] Memory cgroup hierarchy introduction (v3) Balbir Singh
2008-11-11 12:33 ` Balbir Singh
2008-11-11 12:33 ` [RFC][mm] [PATCH 1/4] Memory cgroup hierarchy documentation (v3) Balbir Singh
2008-11-11 12:33 ` Balbir Singh
2008-11-11 12:34 ` [RFC][mm] [PATCH 2/4] Memory cgroup resource counters for hierarchy (v3) Balbir Singh
2008-11-11 12:34 ` Balbir Singh
2008-11-11 12:34 ` [RFC][mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v3) Balbir Singh
2008-11-11 12:34 ` Balbir Singh
2008-11-12 3:52 ` KAMEZAWA Hiroyuki
2008-11-12 3:52 ` KAMEZAWA Hiroyuki
2008-11-12 4:00 ` Balbir Singh [this message]
2008-11-12 4:00 ` Balbir Singh
2008-11-12 5:02 ` KAMEZAWA Hiroyuki
2008-11-12 5:02 ` KAMEZAWA Hiroyuki
2008-11-12 5:49 ` Balbir Singh
2008-11-12 5:49 ` Balbir Singh
2008-11-12 6:01 ` KAMEZAWA Hiroyuki
2008-11-12 6:01 ` KAMEZAWA Hiroyuki
2008-11-12 6:10 ` Balbir Singh
2008-11-12 6:10 ` Balbir Singh
2008-11-12 6:12 ` KAMEZAWA Hiroyuki
2008-11-12 6:12 ` KAMEZAWA Hiroyuki
2008-11-12 6:22 ` Balbir Singh
2008-11-12 6:22 ` Balbir Singh
2008-11-12 6:33 ` KAMEZAWA Hiroyuki
2008-11-12 6:33 ` KAMEZAWA Hiroyuki
2008-11-12 11:21 ` Balbir Singh
2008-11-12 11:21 ` Balbir Singh
2008-11-13 4:18 ` KAMEZAWA Hiroyuki
2008-11-13 4:18 ` KAMEZAWA Hiroyuki
2008-11-13 13:33 ` Balbir Singh
2008-11-13 13:33 ` Balbir Singh
2008-11-11 12:34 ` [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v3) Balbir Singh
2008-11-11 12:34 ` Balbir Singh
2008-11-13 1:28 ` Li Zefan
2008-11-13 1:28 ` Li Zefan
2008-11-13 1:34 ` Balbir Singh
2008-11-13 1:34 ` Balbir Singh
2008-11-13 1:39 ` Li Zefan
2008-11-13 1:39 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491A54EB.3020500@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.