From: Jiri Slaby <jirislaby@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Jiri Kosina <jkosina@suse.cz>, Jiri Kosina <jikos@jikos.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [patch]fix memleak in error case of hiddev
Date: Wed, 12 Nov 2008 16:11:11 +0100 [thread overview]
Message-ID: <491AF20F.3040908@gmail.com> (raw)
In-Reply-To: <200811121555.48488.oliver@neukum.org>
On 11/12/2008 03:55 PM, Oliver Neukum wrote:
> Am Mittwoch, 12. November 2008 15:48:38 schrieb Jiri Kosina:
>> + if (!list->hiddev->open++) {
>> + if (list->hiddev->exist) {
>
> The order of checks is inverted. If the device no longer exists
> opening should fail, even if the device is already opened.
> Didn't I post a patch that does this? My memory is a bit clouded.
This is very old (and broken) version of the patch. I remember I already
commented some issues contained in this one and you did fix them later ;).
prev parent reply other threads:[~2008-11-12 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 9:31 [patch]fix memleak in error case of hiddev Oliver Neukum
2008-10-31 14:08 ` Jiri Kosina
2008-10-31 14:42 ` Oliver Neukum
2008-10-31 15:10 ` Oliver Neukum
2008-11-12 14:48 ` Jiri Kosina
2008-11-12 14:55 ` Oliver Neukum
2008-11-12 14:56 ` Jiri Kosina
2008-11-12 15:11 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491AF20F.3040908@gmail.com \
--to=jirislaby@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@jikos.cz \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.