From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] powerpc: keymile: Add a check for the PIGGY debug board
Date: Wed, 12 Nov 2008 09:43:59 -0800 [thread overview]
Message-ID: <491B15DF.1070805@gmail.com> (raw)
In-Reply-To: <491A98A0.6070107@denx.de>
Hi Heiko,
Heiko Schocher wrote:
> Check the presence of the PIGGY on the keymile boards mgcoge,
> mgsuvd and kmeter1. If the PIGGY is not present, dont register
> this Ethernet device.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
This looks like useful stuff to have, but I'd prefer that you put the
check logic in board_eth_init() rather than adding to the individual
device drivers. I know the 8260 SCC driver is the older style, which
precludes the use of board_eth_init, but I'll convert it if you're able
to test.
regards,
Ben
next prev parent reply other threads:[~2008-11-12 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 8:49 [U-Boot] [PATCH 4/5] powerpc: keymile: Add a check for the PIGGY debug board Heiko Schocher
2008-11-12 17:43 ` Ben Warren [this message]
2008-11-13 7:43 ` Heiko Schocher
2008-11-13 17:30 ` Ben Warren
2008-11-17 8:13 ` Heiko Schocher
2008-11-19 12:35 ` Gary Jennejohn
2008-11-19 13:03 ` Heiko Schocher
2008-11-19 18:14 ` Gary Jennejohn
2008-11-19 17:44 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491B15DF.1070805@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.