All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] PATCH: fix undefined function errors
Date: Wed, 12 Nov 2008 21:59:19 -0500	[thread overview]
Message-ID: <491B9807.30100@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

I ran into errors about undefined functions when building user-mode QEMU for ARM 
Linux after picking up a recent update from trunk.  The attached patch fixes the 
problem.

As I'm not a QEMU maintainer, someone who is will have to check this in....  or 
some alternate fix for the same problem, maybe.

-Sandra


[-- Attachment #2: qemu.log --]
[-- Type: text/x-log, Size: 287 bytes --]

2008-11-12  Sandra Loosemore  <sandra@codesourcery.com>

	* linux-user/syscall.c (do_syscall):  Make #ifdef on
	TARGET_NR_inotify_init, TARGET_NR_inotify_add_watch, and
	TARGET_NR_inotify_rm_watch cases match that used previously 
	in the file, to avoid references to undefined symbols.

[-- Attachment #3: qemu.patch --]
[-- Type: text/x-patch, Size: 1647 bytes --]

Index: linux-user/syscall.c
===================================================================
*** linux-user/syscall.c	(revision 227507)
--- linux-user/syscall.c	(working copy)
*************** abi_long do_syscall(void *cpu_env, int n
*** 6029,6047 ****
          ret = do_futex(arg1, arg2, arg3, arg4, arg5, arg6);
          break;
  #endif
! #ifdef TARGET_NR_inotify_init
      case TARGET_NR_inotify_init:
          ret = get_errno(sys_inotify_init());
          break;
  #endif
! #ifdef TARGET_NR_inotify_add_watch
      case TARGET_NR_inotify_add_watch:
          p = lock_user_string(arg2);
          ret = get_errno(sys_inotify_add_watch(arg1, path(p), arg3));
          unlock_user(p, arg2, 0);
          break;
  #endif
! #ifdef TARGET_NR_inotify_rm_watch
      case TARGET_NR_inotify_rm_watch:
          ret = get_errno(sys_inotify_rm_watch(arg1, arg2));
          break;
--- 6029,6047 ----
          ret = do_futex(arg1, arg2, arg3, arg4, arg5, arg6);
          break;
  #endif
! #if defined(TARGET_NR_inotify_init) && defined(__NR_inotify_init)
      case TARGET_NR_inotify_init:
          ret = get_errno(sys_inotify_init());
          break;
  #endif
! #if defined(TARGET_NR_inotify_add_watch) && defined(__NR_inotify_add_watch)
      case TARGET_NR_inotify_add_watch:
          p = lock_user_string(arg2);
          ret = get_errno(sys_inotify_add_watch(arg1, path(p), arg3));
          unlock_user(p, arg2, 0);
          break;
  #endif
! #if defined(TARGET_NR_inotify_rm_watch) && defined(__NR_inotify_rm_watch)
      case TARGET_NR_inotify_rm_watch:
          ret = get_errno(sys_inotify_rm_watch(arg1, arg2));
          break;

                 reply	other threads:[~2008-11-13  2:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491B9807.30100@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.