Re: [PATCH 1/1] KVM: VMX: Clean up private memory slot allocation

[Avi Kivity <avi@redhat.com>]

Sheng Yang wrote:
> userspace_addr should be a meaningless value.
>   

Perhaps in __kvm_set_memory_region(), if !user_alloc?

Why is it needed?  Did you observe any problem?

> @@ -2022,6 +2022,8 @@ static int alloc_apic_access_page(struct kvm *kvm)
>  	kvm_userspace_mem.flags = 0;
>  	kvm_userspace_mem.guest_phys_addr = 0xfee00000ULL;
>  	kvm_userspace_mem.memory_size = PAGE_SIZE;
> +	/* userspace_addr is invalid, make it unaligned */
> +	kvm_userspace_mem.userspace_addr = PAGE_SIZE - 1;
>  	r = __kvm_set_memory_region(kvm, &kvm_userspace_mem, 0);
>  	if (r)
>  		goto out;
> @@ -2044,6 +2046,8 @@ static int alloc_identity_pagetable(struct kvm *kvm)
>  	kvm_userspace_mem.flags = 0;
>  	kvm_userspace_mem.guest_phys_addr = VMX_EPT_IDENTITY_PAGETABLE_ADDR;
>  	kvm_userspace_mem.memory_size = PAGE_SIZE;
> +	/* userspace_addr is invalid, make it unaligned */
> +	kvm_userspace_mem.userspace_addr = PAGE_SIZE - 1;
>  	r = __kvm_set_memory_region(kvm, &kvm_userspace_mem, 0);
>  	if (r)
>  		goto out;
>   


-- 
error compiling committee.c: too many arguments to function