From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kevin Hao <kexin.hao@windriver.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
gregkh@suse.de, Alan Cox <alan@redhat.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] add device function for usb serial console
Date: Thu, 13 Nov 2008 17:59:14 +0300 [thread overview]
Message-ID: <491C40C2.7000302@ru.mvista.com> (raw)
In-Reply-To: <2fdffab7c5a36049b81ec63f2ee1fbdd4dd25a8a.1226366228.git.kexin.hao@windriver.com>
Hello.
Kevin Hao wrote:
> Add device funtion for usb serial console, so we can open /dev/console
> when we use a usb serial device as console.
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index 5b95009..1dbb203 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -241,12 +241,25 @@ static void usb_console_write(struct console *co,
> }
> }
>
> +static struct tty_driver *usb_console_device(struct console *co, int *index)
> +{
> + struct tty_driver **p = (struct tty_driver **)co->data;
> +
> + if (!*p)
> + return NULL;
> +
> + *index = co->index;
> + return (struct tty_driver *)(*p);
Type cast not needed here.
WBR, Sergei
next prev parent reply other threads:[~2008-11-13 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 1:53 [PATCH 0/2] fix two bugs in usb serial console Kevin Hao
2008-11-13 1:53 ` [PATCH 1/2] init tty kref in usb serial console setup Kevin Hao
2008-11-13 1:53 ` [PATCH 2/2] add device function for usb serial console Kevin Hao
2008-11-13 14:59 ` Sergei Shtylyov [this message]
2008-11-14 1:30 ` [PATCH v2] " Kevin Hao
2008-11-14 22:36 ` [PATCH 2/2] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491C40C2.7000302@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@redhat.com \
--cc=gregkh@suse.de \
--cc=kexin.hao@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.