Re: [Qemu-devel] [PATCH] Fix crash on 'info vnc' after 'change vnc none'

[Anthony Liguori <anthony@codemonkey.ws>]

James Ko wrote:
> I propose the following patch to prevent crash in call to 
> term_print_filename
> with NULL vnc_state->display argument from do_info_vnc.
>
> vnc_state->display is set to NULL after "change vnc none" but 
> vnc_state itself
> is still valid.
>
> James

Please include a Signed-off-by.

Regards,

Anthony Liguori

> diff -aru a/qemu/vnc.c b/qemu/vnc.c
> --- a/qemu/vnc.c  2008-08-21 17:46:40.000000000 -0700
> +++ b/qemu/vnc.c  2008-11-06 14:31:51.000000000 -0800
> @@ -180,7 +180,7 @@
>
>  void do_info_vnc(void)
>  {
> -    if (vnc_state == NULL)
> +    if (vnc_state == NULL || vnc_state->display == NULL)
>      term_printf("VNC server disabled\n");
>      else {
>      term_printf("VNC server active on: ");
>
>