From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Blunck <jblunck@suse.de>,
containers@lists.osdl.org,
Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: reduce size of per-cpu-stat to be appropriate size.
Date: Fri, 14 Nov 2008 13:33:49 +0530 [thread overview]
Message-ID: <491D30E5.7080608@linux.vnet.ibm.com> (raw)
In-Reply-To: <491D2E6C.1000009@cn.fujitsu.com>
Li Zefan wrote:
>>>> +static int mem_cgroup_size(void)
>>> inline this function?
>>>
>> necessary ?
>>
>
> Not so necessary IMO. It's called when a cgroup is created and removed, that
> is mkdir and rmdir, where performance is not critical.
>
I think most new compilers can automatically inline such functions, but a hint
for the older ones is always a good practice.
--
Balbir
next prev parent reply other threads:[~2008-11-14 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 16:42 [PATCH] Dynamically allocate struct mem_cgroup_stat_cpu memory Jan Blunck
2008-11-14 3:18 ` Andrew Morton
2008-11-14 3:52 ` Li Zefan
2008-11-14 4:28 ` KAMEZAWA Hiroyuki
2008-11-14 5:49 ` [PATCH] memcg: reduce size of per-cpu-stat to be appropriate size KAMEZAWA Hiroyuki
2008-11-14 6:26 ` Li Zefan
2008-11-14 7:18 ` [PATCH] memcg: reduce size of per-cpu-stat to be appropriate size.(v2) KAMEZAWA Hiroyuki
2008-11-14 7:43 ` [PATCH] memcg: reduce size of per-cpu-stat to be appropriate size Balbir Singh
2008-11-14 7:48 ` KAMEZAWA Hiroyuki
2008-11-14 7:53 ` Li Zefan
2008-11-14 8:03 ` Balbir Singh [this message]
2008-11-14 8:06 ` KAMEZAWA Hiroyuki
2008-11-14 7:57 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491D30E5.7080608@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=jblunck@suse.de \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.