All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: NR_PIRQS vs. NR_IRQS
Date: Fri, 14 Nov 2008 08:19:02 +0000	[thread overview]
Message-ID: <491D4286.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C542E0A5.1F377%keir.fraser@eu.citrix.com>

>>> Keir Fraser <keir.fraser@eu.citrix.com> 14.11.08 09:00 >>>
>On 14/11/08 07:54, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
>
>>>> I agree with keeping this naming distinction of course, although I think
>>>> allowing NR_IRQS > NR_VECTORS right now is not very useful. But maybe you
>>>> have a box in mind that needs it?
>>> 
>>> I had sent a mail a few days ago on this, where IBM was testing 96 CPU
>>> support (4-node system), and it crashing because of a PIRQ ending up in
>>> DYNIRQ space (kernel perspective), because there being 300+ IO-APIC
>>> pins. While the crash ought to be fixed with the subsequent patch, it's
>>> clear that none of the devices with an accumulated pin number greater
>>> than 255 will actually work on that system.
>> 
>> Oh dear. :-D
>
>Is fixing this actually any harder than just bumping NR_IRQS/NR_PIRQS in Xen
>and NR_PIRQS in Linux? Have IRQS and VECTORS got somehow accidentally tied
>together in Xen?

Perhaps not, but I only started checking (on the Xen side - the kernel side
has no issues, already bumped the value there). I'll continue as time permits.

>These parameters should probably be build-time configurable.

That'd certainly be nice for NR_IRQS (it seems we agreed to get rid of
NR_PIRQS). I can't the same being valid for NR_VECTORS, though.

Jan

  reply	other threads:[~2008-11-14  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 16:59 NR_PIRQS vs. NR_IRQS Jan Beulich
2008-11-13 18:41 ` Keir Fraser
2008-11-13 19:19   ` Keir Fraser
2008-11-14  7:48     ` Jan Beulich
2008-11-14  7:54       ` Keir Fraser
2008-11-14  8:00         ` Keir Fraser
2008-11-14  8:19           ` Jan Beulich [this message]
2008-11-14  8:31             ` Keir Fraser
2008-11-14 19:27           ` Jeremy Fitzhardinge
2008-11-19 15:55           ` Jan Beulich
2008-11-19 16:09             ` Keir Fraser
2008-11-19 16:23               ` Jan Beulich
2008-11-19 16:33                 ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491D4286.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.