From: Yu Zhao <yu.zhao@uniscape.net>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "Zhao, Yu" <yu.zhao@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Grant Grundler <grundler@parisc-linux.org>,
Alex Chiang <achiang@hp.com>, Roland Dreier <rdreier@cisco.com>,
Greg KH <greg@kroah.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 6/6 v3] PCI: document the change
Date: Sat, 15 Nov 2008 20:38:55 +0800 [thread overview]
Message-ID: <491EC2DF.2070704@uniscape.net> (raw)
In-Reply-To: <20081001160706.GI13822@parisc-linux.org>
Matthew Wilcox wrote:
> On Sat, Sep 27, 2008 at 04:28:45PM +0800, Zhao, Yu wrote:
>> +To register SR-IOV service, Physical Function device driver needs to call:
>> + int pci_iov_register(struct pci_dev *dev,
>> + int (*notify)(struct pci_dev *, u32), char **entries)
>
> I think a better interface would put the 'notify' into the struct
> pci_driver. That would make 'notify' a bad name .... how about
> 'virtual'? There's also no documentation for the second parameter to
> 'notify'.
Yes, putting the callback function to the 'pci_driver' is better. Looks
like the 'virtual' is not very descriptive (and it's a adj. while other
callbacks are verb). Any other candidates?
Thanks,
Yu
next prev parent reply other threads:[~2008-11-15 12:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 8:28 [PATCH 6/6 v3] PCI: document the change Zhao, Yu
2008-10-01 16:07 ` Matthew Wilcox
2008-10-01 16:07 ` Matthew Wilcox
2008-10-14 0:23 ` Dong, Eddie
2008-10-14 1:08 ` Matthew Wilcox
2008-10-14 1:08 ` Matthew Wilcox
2008-10-14 2:31 ` Dong, Eddie
2008-10-14 2:14 ` Yu Zhao
2008-10-14 4:01 ` Matthew Wilcox
2008-10-14 4:06 ` Yu Zhao
2008-10-14 4:06 ` Yu Zhao
2008-10-14 4:18 ` Dong, Eddie
2008-10-14 4:18 ` Dong, Eddie
2008-10-14 4:46 ` Matthew Wilcox
2008-10-17 5:48 ` Anirban Chakraborty
2008-10-17 5:48 ` Anirban Chakraborty
2008-10-14 4:46 ` Matthew Wilcox
2008-10-14 4:01 ` Matthew Wilcox
2008-10-14 2:14 ` Yu Zhao
2008-10-14 2:31 ` Dong, Eddie
2008-10-14 0:23 ` Dong, Eddie
2008-11-15 12:38 ` Yu Zhao [this message]
2008-11-15 12:38 ` Yu Zhao
-- strict thread matches above, loose matches on Subject: below --
2008-09-27 8:28 Zhao, Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491EC2DF.2070704@uniscape.net \
--to=yu.zhao@uniscape.net \
--cc=achiang@hp.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.