From: Ned Forrester <nforrester-/d+BM93fTQY@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [patch 2.6.28-rc4] spi: pxa2xx_spi.c fix DMA mapping sequence
Date: Sat, 15 Nov 2008 16:21:18 -0500 [thread overview]
Message-ID: <491F3D4E.8080502@whoi.edu> (raw)
In-Reply-To: <491F3C1A.1030402-/d+BM93fTQY@public.gmane.org>
Ned Forrester wrote:
> From: Ned Forrester <nforrester-/d+BM93fTQY@public.gmane.org>
>
> Fixes a bug in pxa2xx_spi.c when operating in direct memory access
> (DMA) mode. The transmit and receive buffers are allowed to be the
> same or to overlap, but pxa2xx_spi.c fails if this is attempted in DMA
> mode because it performs mapping of the rx and tx buffers in the wrong
> order. By mapping DMA_FROM_DEVICE before DMA_TO_DEVICE, it invalidates
> the cache before flushing it. The patch corrects the order of
> mapping. This bug exists in all versions of pxa2xx_spi.c
David,
Assuming that you accept this patch, may I attach your Ack: and forward
this to stable along with a version for kernels older than 2.6.27, or
would you prefer to forward this to stable directly and for me to also
post the the older patch to spi-devel-general for your attention?
--
Ned Forrester nforrester-/d+BM93fTQY@public.gmane.org
Oceanographic Systems Lab 508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next prev parent reply other threads:[~2008-11-15 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 21:16 [patch 2.6.28-rc4] spi: pxa2xx_spi.c fix DMA mapping sequence Ned Forrester
[not found] ` <491F3C1A.1030402-/d+BM93fTQY@public.gmane.org>
2008-11-15 21:21 ` Ned Forrester [this message]
[not found] ` <491F3D4E.8080502-/d+BM93fTQY@public.gmane.org>
2008-11-15 22:09 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491F3D4E.8080502@whoi.edu \
--to=nforrester-/d+bm93ftqy@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.