All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Kohlbecher <xt28@gmx.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] x86: more general identifier for Phoenix BIOS
Date: Sun, 16 Nov 2008 12:11:01 +0100	[thread overview]
Message-ID: <491FFFC5.9080006@gmx.de> (raw)
In-Reply-To: <20081116072300.GB19646@elte.hu>

Phoenix BIOSes variously identify their vendor as "Phoenix Technologies, 
LTD" or "Phoenix Technologies LTD" (without the comma.)

This patch makes the identification string in the bad_bios_dmi_table 
more general (following a suggestion by Ingo Molnar), so that both 
versions are handled.

Again, the patched file compiles cleanly and the patch has been tested 
successfully on my machine.

Signed-off-by: Philipp Kohlbecher <xt28@gmx.de>

---

  arch/x86/kernel/setup.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..9d5674f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -764,7 +764,7 @@ static struct dmi_system_id __initdata 
bad_bios_dmi_table[] = {
  		.callback = dmi_low_memory_corruption,
  		.ident = "Phoenix BIOS",
  		.matches = {
-			DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies, LTD"),
+			DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies"),
  		},
  	},
  #endif

Ingo Molnar wrote:
> * H. Peter Anvin <hpa@zytor.com> wrote:
> 
>> Philipp Kohlbecher wrote:
>>> My laptop (a Samsung X20) contains a Phoenix BIOS and would 
>>> benefit from patch 1e22436eba84edfec9c25e5a25d09062c4f91ca9 (x86: 
>>> reserve low 64K on AMI and Phoenix BIOS boxen).
>>>
>>> However, according to /sys/class/dmi/id/bios_vendor, the BIOS 
>>> identifies its vendor as "Phoenix Technologies LTD" (sans the 
>>> comma).
> 
> Note that we should do a simpler patch: just change the string to 
> "Phoenix Technologies" and that will provide a proper match. (DMI 
> matches work on substrings too)
> 

Done. (I wasn't sure whether you were saying that *I* should write this 
simpler patch or that you would. Anyway, here it is.)

  reply	other threads:[~2008-11-16 11:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-15 15:42 [PATCH] x86: alternative identifier for Phoenix BIOS Philipp Kohlbecher
2008-11-16  1:55 ` H. Peter Anvin
2008-11-16  7:23   ` Ingo Molnar
2008-11-16 11:11     ` Philipp Kohlbecher [this message]
2008-11-18 15:12       ` [PATCH v2] x86: more general " Ingo Molnar
2008-11-16 11:14   ` [PATCH] x86: alternative " Alan Cox
2008-11-18 15:06     ` Ingo Molnar
2008-11-16 16:51   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491FFFC5.9080006@gmx.de \
    --to=xt28@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.