From: Avi Kivity <avi@redhat.com>
To: Bill Rieske <BRIESKE@novell.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] bios: resolve memory device roll over reporting issues with >32G guests
Date: Sun, 16 Nov 2008 18:09:58 +0200 [thread overview]
Message-ID: <492045D6.1060803@redhat.com> (raw)
In-Reply-To: <4917FF62.860B.008B.3@novell.com>
Bill Rieske wrote:
>> Instead of this, can you add an snprintf() (in a separate patch) and use
>> it? There's already a vsnprintf() so all the heavy machinery is in place.
>>
> Nice catch much cleaner
>
> The field within the Memory Device type 17 is only a word with the MSB being
> used to report MB/KB. Thereby, a guest with 32G and greater would report
> incorrect memory device information rolling over to 0.
> This presents more than one memory device and associated memory structures
> if the memory is larger than 16G
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-11-16 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 21:55 [PATCH] bios: resolve memory device roll over reporting issues with >32G guests Bill Rieske
2008-11-09 13:15 ` Avi Kivity
2008-11-10 16:31 ` Bill Rieske
2008-11-16 16:09 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492045D6.1060803@redhat.com \
--to=avi@redhat.com \
--cc=BRIESKE@novell.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.