All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: pnfs@linux-nfs.org
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>, linux-nfs@vger.kernel.org
Subject: Re: [pnfs] [RFC 01/85] sunrpc: get rid of rpc_rqst.rq_bufsize
Date: Mon, 17 Nov 2008 15:17:57 +0200	[thread overview]
Message-ID: <49216F05.4090706@panasas.com> (raw)
In-Reply-To: <1226347159-6561-1-git-send-email-bhalevy@panasas.com>

On Nov. 10, 2008, 21:59 +0200, Benny Halevy <bhalevy@panasas.com> wrote:
> rq_bufsize is not used.
> 
> Signed-off-by: Mike Sager <Mike.Sager@netapp.com>
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> ---
>  include/linux/sunrpc/xprt.h |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
> index 4d80a11..11fc71d 100644
> --- a/include/linux/sunrpc/xprt.h
> +++ b/include/linux/sunrpc/xprt.h
> @@ -76,8 +76,7 @@ struct rpc_rqst {
>  	struct list_head	rq_list;
>  
>  	__u32 *			rq_buffer;	/* XDR encode buffer */
> -	size_t			rq_bufsize,

review 11-14: this was used in the past as a sanity check.
find out when/why this functionality was ripped out.

> -				rq_callsize,
> +	size_t			rq_callsize,
>  				rq_rcvsize;
>  
>  	struct xdr_buf		rq_private_buf;		/* The receive buffer
> -- 
> 1.6.0.1
> 

  reply	other threads:[~2008-11-17 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 19:59 [RFC 01/85] sunrpc: get rid of rpc_rqst.rq_bufsize Benny Halevy
2008-11-17 13:17 ` Benny Halevy [this message]
2008-11-18  8:42   ` [pnfs] " Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49216F05.4090706@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.