All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Barkowski <michael.barkowski@freescale.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc832x_rdb: fix swapped ethernet ids
Date: Mon, 17 Nov 2008 11:28:52 -0500	[thread overview]
Message-ID: <49219BC4.7050803@freescale.com> (raw)
In-Reply-To: <20081115022637.GC6629@yookeroo.seuss>

David Gibson wrote:
> On Fri, Nov 14, 2008 at 10:16:19AM -0500, Michael Barkowski wrote:
>> David Gibson wrote:
>>> On Thu, Nov 13, 2008 at 10:18:28AM -0500, Michael Barkowski wrote:
>>>> ethernet0 (called FSL UEC0 in U-Boot) should be enet1 (UCC3/eth1), and
>>>> ethernet1 should be enet0 (UCC2/eth0), to be consistent with U-Boot so
>>>> that the interfaces do not swap addresses when control passes from
>>>> U-Boot to the kernel.
>>> Um.. why is just swapping the aliases, rather than the enet labels the
>>> right approach here?
>> Kim suggested it was better to localize the port ordering as a
>> property of the board rather than that of the QE, and I agreed.
> 
> And the enet0/enet1 names that appear in the labels come from the QE
> documentation?
> 
No.. but don't you think the UCC2, UCC3 names, which *do* come from the QE documentation, should match their labels in numeric ordering?
Aren't the aliases just machine-specific shortcuts for the bootloader?

-- 
Michael

  reply	other threads:[~2008-11-17 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 15:18 [PATCH] mpc832x_rdb: fix swapped ethernet ids Michael Barkowski
2008-11-13 23:45 ` David Gibson
2008-11-14 15:16   ` Michael Barkowski
2008-11-15  2:26     ` David Gibson
2008-11-17 16:28       ` Michael Barkowski [this message]
2008-11-18  0:17         ` David Gibson
2008-11-18 15:02           ` Michael Barkowski
2008-11-19 21:10 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49219BC4.7050803@freescale.com \
    --to=michael.barkowski@freescale.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.