Re: [PATCH] net: Cleanup of af_unix

[Eric Dumazet <dada1@cosmosbay.com>]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Joe Perches a écrit :
> On Mon, 2008-11-17 at 07:46 +0100, Eric Dumazet wrote:
>> [PATCH] net: Cleanup of af_unix
>>
>> This is a pure cleanup of net/unix/af_unix.c to meet current code style standards
>>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>> --- 
>>  net/unix/af_unix.c |  117 ++++++++++++++++++++-----------------------
>>  1 files changed, 55 insertions(+), 62 deletions(-)
>> plain text document attachment (af_unix_cleanup.patch)
>> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
>> index 4a39771..58db2a2 100644
>> --- a/net/unix/af_unix.c
>> +++ b/net/unix/af_unix.c
>> @@ -354,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk)
>>  	WARN_ON(!sk_unhashed(sk));
>>  	WARN_ON(sk->sk_socket);
>>  	if (!sock_flag(sk, SOCK_DEAD)) {
>> -		printk("Attempt to release alive unix socket: %p\n", sk);
>> +		printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", sk);
>>  		return;
>>  	}
>>  
> 
> Well, perhaps not quite pure.
> The KERN_ level selection is debatable.
> This could or perhaps should be KERN_INFO.

Thanks Joe

[PATCH] net: af_unix should use KERN_INFO instead of KERN_DEBUG

As spotted by Joe Perches, we should use KERN_INFO in unix_sock_destructor()

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

[-- Attachment #2: af_unix_printk.patch --]
[-- Type: text/plain, Size: 453 bytes --]

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index f2cf3f5..da3e804 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -353,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk)
 	WARN_ON(!sk_unhashed(sk));
 	WARN_ON(sk->sk_socket);
 	if (!sock_flag(sk, SOCK_DEAD)) {
-		printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", sk);
+		printk(KERN_INFO "Attempt to release alive unix socket: %p\n", sk);
 		return;
 	}