From: "H. Peter Anvin" <hpa@zytor.com>
To: Shem Multinymous <multinymous@gmail.com>
Cc: "J.R. Mauro" <jrm8005@gmail.com>,
tpctl-users@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Tpctl-users] Inclusion of tp_smapi module into kernel?
Date: Mon, 17 Nov 2008 11:21:09 -0800 [thread overview]
Message-ID: <4921C425.7020806@zytor.com> (raw)
In-Reply-To: <41840b750811171035w63c794aepaa273bc55fbaf2@mail.gmail.com>
Shem Multinymous wrote:
> On Mon, Nov 17, 2008 at 12:13 PM, J.R. Mauro <jrm8005@gmail.com> wrote:
>> There are several utilities maintained by this author, and finding
>> some way to merge the code has been tried more than once. If you look
>> back far enough, Andrew asked to have another of the project's members
>> sign off on the patch, and maybe that would be acceptable enough, but
>> afaik the author has never responded directly to that idea.
>
> We've discussed that in private at the time, and recently on LKML too.
> In summary:
> I'm fine with that, and so is everybody I talked to (including Linus),
> except Greg KH who vetoed it since he believes the code is irrevocably
> and contagiously evil.
>
Signed-off-by is about copyright, it's not a review issue. It means "I
certify that I know that the author had the rights to submit this code."
Code quality is important but separate.
-hpa
next prev parent reply other threads:[~2008-11-17 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 13:55 Inclusion of tp_smapi module into kernel? Hanno Böck
2008-11-17 16:38 ` H. Peter Anvin
2008-11-17 17:13 ` J.R. Mauro
2008-11-17 18:35 ` [Tpctl-users] " Shem Multinymous
2008-11-17 18:49 ` J.R. Mauro
2008-11-17 19:21 ` H. Peter Anvin [this message]
2008-11-17 20:27 ` Theodore Tso
2008-11-23 12:30 ` Pavel Machek
2008-11-17 20:35 ` Miklos Szeredi
2008-11-18 13:48 ` Henrique de Moraes Holschuh
2008-11-18 17:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4921C425.7020806@zytor.com \
--to=hpa@zytor.com \
--cc=jrm8005@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=multinymous@gmail.com \
--cc=tpctl-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.