All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com,
	netdev@vger.kernel.org
Subject: Re: [v2,PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk
Date: Mon, 17 Nov 2008 14:40:32 -0500	[thread overview]
Message-ID: <4921C8B0.9060301@redhat.com> (raw)
In-Reply-To: <20081116.191252.80669091.davem@davemloft.net>

David Miller wrote:
> I'm less than thrilled with this patch so I'm not going to apply it.
> 
> I mean, what are we going to do, for every single device that has a
> NVRAM we're going to add some PCI quirk and some new global foo_*
> kernel command line option to turn it off?
> 
> That doesn't make any sense at all, sorry.

Could we protect it in a PCI quirk, and optionally unprotect it in the 
driver?

-- Chris

  reply	other threads:[~2008-11-17 19:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  3:12 [v2,PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk David Miller
2008-11-17 19:40 ` Chris Snook [this message]
2008-11-17 19:49   ` David Miller
2008-11-17 20:02     ` Allan, Bruce W
2008-11-17 20:12       ` Ben Hutchings
2008-11-17 20:20       ` David Miller
2008-11-17 23:56         ` Allan, Bruce W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4921C8B0.9060301@redhat.com \
    --to=csnook@redhat.com \
    --cc=bruce.w.allan@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.