From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhai, Edwin" Subject: Re: several Qs about domain live migration Date: Tue, 18 Nov 2008 17:35:06 +0800 Message-ID: <49228C4A.4090205@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "Tian, Kevin" , Xen Developers , "Zhai, Edwin" List-Id: xen-devel@lists.xenproject.org Keir, As my test, video mem and vlapic page are okay, but share page is still treated as ram. After going through the source code, I think this should be "no harm". Although xc_domain_restore populate a new share page first, PV driver in HVM guest will remap share page when resume, thus destroying previous mapping and releasing previous page. So we want to use this simple patch, or mark the share page "not ram"? Keir Fraser wrote: > On 18/11/08 08:22, "Zhai, Edwin" wrote: > > >> Try changing gmfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e)) in mod_l1_entry() > >> to: > >> mfn = gfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e), &p2mt); > >> if ( !p2m_is_ram(p2mt) || (mfn == INVALID_MFN) ) > >> .... > >> > >> This will prevent foreign mappings of 'mmio' pages. Pretty sensible and will > >> fix this problem. > >> > > It's great! > > Does p2m_is_ram return 1 for video memory? > > Yes, since it is just ordinary guest memory. That was the point of Samuel's > patch. > > -- Keir > > > I'll make a small patch and test it. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > -- best rgds, edwin