Re: Advice wanted on producing an in kernel sq905 driver

[Hans de Goede <j.w.r.degoede@hhs.nl>]

Erik Andrén wrote:

<snip>

>> Correct, there is nothing special you need to do for that, just pass frames
>> with the raw bayer data to userspace and set the pixelformat to one of:
>> V4L2_PIX_FMT_SBGGR8 /* v4l2_fourcc('B', 'A', '8', '1'), 8 bit BGBG.. GRGR..
>> */
>> V4L2_PIX_FMT_SGBRG8 /* v4l2_fourcc('G', 'B', 'R', 'G'), 8 bit GBGB.. RGRG..
>> */
>> V4L2_PIX_FMT_SGRBG8 /* v4l2_fourcc('G','R','B','G'), 8 bit GRGR.. BGBG.. */
>> V4L2_PIX_FMT_SRGGB8 /* v4l2_fourcc('R','G','G','B'), 8 bit RGRG.. GBGB.. */
>>
>> Note the last 2 currently are only defined internally in libv4l and not in
>> linux/videodev2.h as no drivers use them yet, but if you need one of them
>> adding it to linux/videodev2.h is fine.
> 
> I'm currently developing a driver where I need the two lower ones in
> order to get a correct bayer decoding.
> Would it possible to add them into the linux/videodev2.h?
> 
> I can send a patch tonight if required.
> 

It is usual for such patches to be submitted together with the driver using the 
new defines. Just be sure you define
V4L2_PIX_FMT_SGRBG8 as v4l2_fourcc('G','R','B','G')
and
V4L2_PIX_FMT_SRGGB8 as v4l2_fourcc('R','G','G','B')

You can try sending a patch to Mauro as preperation for your driver, but I'm 
not sure he will take such a patch, he did not accept it from me in the past as 
no drivers were using them, maybe with a driver on the horizon he will accept 
such a patch.

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list