From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix media detection on emulated CDROM
Date: Tue, 18 Nov 2008 13:18:09 -0600 [thread overview]
Message-ID: <492314F1.20900@codemonkey.ws> (raw)
In-Reply-To: <1227032396.17638.60.camel@ggrebus.katana-technology.com>
Gary Grebus wrote:
> This patch tweaks the ATAPI CDROM emulation to fix an annoyance seen
> when running a variety of Linux guests: the desktop GUI shows a CDROM
> device as present, but is unable to automount the media and display its
> contents.
>
> The patch adds the PLAY_AUDIO capability bit to the data returned by
> MODE_SENSE commands. That convinces the guest kernel to determine what
> kind of media is present.
>
> Arguably Linux could be smarter about this, but it's my guess there are
> few (if any) hardware CDROM drives that don't set the bit, and there are
> a large number of Linux distros that exhibit this problem.
>
> Signed-off-by: Gary Grebus <ggrebus@virtualiron.com>
>
>
Could you please include a comment to this effect in the code?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-11-18 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 18:19 [Qemu-devel] [PATCH] Fix media detection on emulated CDROM Gary Grebus
2008-11-18 19:18 ` Anthony Liguori [this message]
2008-11-19 14:46 ` Gary Grebus
2008-11-19 15:03 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492314F1.20900@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.