From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2ZIz-0008Dd-B4 for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:44:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2ZIy-0008CS-EI for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:44:20 -0500 Received: from [199.232.76.173] (port=36727 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2ZIx-0008CH-Tr for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:44:20 -0500 Received: from nf-out-0910.google.com ([64.233.182.189]:38037) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2ZIx-0005AJ-Vy for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:44:20 -0500 Received: by nf-out-0910.google.com with SMTP id b2so2456457nfb.12 for ; Tue, 18 Nov 2008 14:44:18 -0800 (PST) Message-ID: <4923453D.5050307@codemonkey.ws> Date: Tue, 18 Nov 2008 16:44:13 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support References: <1226956692-15962-1-git-send-email-hollisb@us.ibm.com> <09739678475eecbf3d9de512bf1dd13d07bd6642.1226955410.git.hollisb@us.ibm.com> <9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com> <49233BDA.7030807@codemonkey.ws> <1227046673.3431.2.camel@localhost.localdomain> In-Reply-To: <1227046673.3431.2.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hollis Blanchard wrote: >> Also note that there are multiple implementations of unzip in QEMU right >> now so you could refactor one of those into common code. >> > > Are there? grep didn't find them; can you point me at some? > $ grep inflateInit *.c block-cloop.c: if(inflateInit(&s->zstream) != Z_OK) block-dmg.c: if(inflateInit(&s->zstream) != Z_OK) block-qcow2.c: ret = inflateInit2(strm, -12); block-qcow.c: ret = inflateInit2(strm, -12); vl.c: ret = inflateInit(&s->zstream); The closest to what you're looking for is probably decompress_buffer() in block-qcow2.c Regards, Anthony Liguori