All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] kvm: memory aliasing support for kvm
Date: Wed, 19 Nov 2008 09:07:06 -0600	[thread overview]
Message-ID: <49242B9A.7090001@codemonkey.ws> (raw)
In-Reply-To: <1227108377-8442-2-git-send-email-glommer@redhat.com>

Glauber Costa wrote:
> We use information encoded in phys_offset to support memory
> alias for kvm-all.c. Recall that for any given memory slot,
> userspace_addr = phys_ram_base + phys_offset (without any flags).
>
> This way, we can detect whether or not the registered slot is
> effectively pointing to the same area, regardless of the fact
> that it has a different guest_phys_addr.
>   

I think we've missed the abstraction here.  If you added an arch hook 
for kvm_set_phys_mem(), then you could have hidden the alias stuff 
entirely within target-i386/x86.c

But we can fix that up later.

Regards,

Anthony Liguori

  reply	other threads:[~2008-11-19 15:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 15:26 [Qemu-devel] [PATCH 0/6] New shot at VGA optimization Glauber Costa
2008-11-19 14:23 ` Avi Kivity
2008-11-19 14:34   ` Glauber Costa
2008-11-19 15:26 ` [Qemu-devel] [PATCH 1/6] kvm: memory aliasing support for kvm Glauber Costa
2008-11-19 15:07   ` Anthony Liguori [this message]
2008-11-19 15:26   ` [Qemu-devel] [PATCH 2/6] better type checking for vga Glauber Costa
2008-11-19 15:08     ` Anthony Liguori
2008-11-19 15:26     ` [Qemu-devel] [PATCH 3/6] move vga_io_address to VGA State Glauber Costa
2008-11-19 15:26       ` [Qemu-devel] [PATCH 4/6] kvm: de-register mem region for MMIO Glauber Costa
2008-11-19 15:10         ` Anthony Liguori
2008-11-19 15:26         ` [Qemu-devel] [PATCH 5/6] Introduce kvm logging interface Glauber Costa
2008-11-19 15:18           ` Anthony Liguori
2008-11-19 17:23             ` Glauber Costa
2008-11-19 17:51               ` Anthony Liguori
2008-11-19 15:26           ` [Qemu-devel] [PATCH 6/6] kvm: vga optimization Glauber Costa
2008-11-19 15:23             ` Anthony Liguori
2008-11-19 17:19               ` Glauber Costa
2008-11-19 17:26                 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49242B9A.7090001@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.