From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Andy Whitcroft <apw@canonical.com>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org
Subject: Re: [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h
Date: Wed, 19 Nov 2008 19:38:34 +0100 [thread overview]
Message-ID: <49245D2A.5090106@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0811191926590.4486@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Wednesday 2008-11-19 19:08, Patrick McHardy wrote:
>
>> Andy Whitcroft wrote:
>>> It seems that all of the include/netfilter_{ipv4,ipv6}/{ipt,ip6t}_*.h which
>>> share constants include the corresponding include/netfilter/xp_*.h files.
>>> Neither ipt_policy.h not ip6t_policy.h do. Make these consistant with
>>> the norm.
>> Does this actually fix a bug, or is it just for added consistency?
>
> This can only be consistency, because every compile error would
> be easy to fix by inclusion of xt_policy.h in the corresponding
> .c file.
It would also be easily fixed by this patch. Lets see what Andy
has to say.
> Which reminds me, when can we get rid of the ipt_*h files?
There is external code using these headers, so not at this point.
We could schedule them for removal, but I don't see point, keeping
those headers don't cause any maintenance work.
next prev parent reply other threads:[~2008-11-19 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:21 [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h Andy Whitcroft
2008-11-19 18:08 ` Patrick McHardy
2008-11-19 18:27 ` Jan Engelhardt
2008-11-19 18:38 ` Patrick McHardy [this message]
2008-11-20 9:45 ` Andy Whitcroft
2008-11-20 9:47 ` Patrick McHardy
2008-11-20 10:37 ` Andy Whitcroft
2008-11-20 10:38 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49245D2A.5090106@trash.net \
--to=kaber@trash.net \
--cc=apw@canonical.com \
--cc=coreteam@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.