From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrik Rydberg Subject: Re: [PATCH] hid: Complete support for the new unibody macbooks Date: Thu, 20 Nov 2008 00:10:03 +0100 Message-ID: <49249CCB.7060807@euromail.se> References: <49109C91.6090207@euromail.se> <4919C979.3000501@euromail.se> <20081119113753.ZZRA012@mailhub.coreip.homeip.net> <49249431.9040104@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:51997 "EHLO ch-smtp02.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbYKSXKG (ORCPT ); Wed, 19 Nov 2008 18:10:06 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Dmitry Torokhov , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Jiri Kosina wrote: > On Wed, 19 Nov 2008, Henrik Rydberg wrote: > >> Without the mouse ignore quirk, HID will find the "normal" usb mouse >> interface. The current situation is much worse than to throw the bcm5974 >> patches in untested. And this is not even the case; the updated driver >> has been in use as a dkms package for almost a month. > > Therefore my memory must have been wrong -- I thought that you told me > when I was merging f89bd95c5c that the devices are not standard HID > devices at all, and therefore they can be safely ignored by the driver > right away, as they can't be driven by HID driver anyway. These usb devices provide several different functions through the same interface. By default, it looks like a regular mouse interface, which HID will claim. This is why we need the quirks. > If this is not the case, I'll then revert the hid_mouse_ignore_list[] > addition peformed in a96d6ef34 and will push it for 2.6.29, so that it > goes in together with bcm5974 driver modifications. Yes, I think that is best. > Thanks and sorry if I messed this up, No harm done. :-) Thanks, Henrik