From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>
Subject: Re: [PATCH] ath9k: Dont update rate control for every AMPDU
Date: Thu, 20 Nov 2008 11:27:04 +0530 [thread overview]
Message-ID: <4924FC30.7080906@atheros.com> (raw)
In-Reply-To: <1227205528.3766.29.camel@johannes.berg>
Johannes Berg wrote:
> On Thu, 2008-11-20 at 11:21 +0530, Vasanthakumar Thiagarajan wrote:
>
>> + u8 update_rc;
>
>> + tx_info_priv->update_rc = 0;
>
>> + tx_info_priv->update_rc = 1;
>
> You could use a bool and use false/true, that'd generate exactly the
> same code but might be easier to read. Not that it matters much I guess.
>
> johannes
Sure, if it improves the readability.
Vasanth
next prev parent reply other threads:[~2008-11-20 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 5:51 [PATCH] ath9k: Dont update rate control for every AMPDU Vasanthakumar Thiagarajan
2008-11-20 18:25 ` Johannes Berg
2008-11-20 5:57 ` Vasanthakumar Thiagarajan [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-20 6:21 Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4924FC30.7080906@atheros.com \
--to=vasanth@atheros.com \
--cc=Jouni.Malinen@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.