From: Steven A. Falco <sfalco@harris.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h
Date: Thu, 20 Nov 2008 14:37:57 -0500 [thread overview]
Message-ID: <4925BC95.9070107@harris.com> (raw)
In-Reply-To: <200811201907.19607.sr@denx.de>
The definitions of bits in SDR_CFG are incorrect, and not used within
U-Boot. Therefore, they can be removed.
The naming of the sdr_ddrdl/sdr_cfg registers do not follow conventions,
and are unused, so they can be removed too.
A definition for SDR0_DDRCFG is added.
Signed-off-by: Steven A. Falco <sfalco@harris.com>
---
As per Stefan's request, here is a patch removing the unused, incorrect
definitions.
Note that the AMCC DDR spreadsheet does calculate a value for the
sdr_cfg register, and I want to use that in a new board design (not yet
ready for submission), so I've added the SDR0_DDRCFG definition.
diff --git a/include/ppc440.h b/include/ppc440.h
index c581f1b..2d64ed6 100644
--- a/include/ppc440.h
+++ b/include/ppc440.h
@@ -170,18 +170,9 @@
#define sdr_ecid1 0x0081
#define sdr_ecid2 0x0082
#define sdr_jtag 0x00c0
-#if !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX)
-#define sdr_ddrdl 0x00e0
-#else
-#define sdr_cfg 0x00e0
-#define SDR_CFG_LT2_MASK 0x01000000 /* Leakage test 2*/
-#define SDR_CFG_64_32BITS_MASK 0x01000000 /* Switch DDR 64 bits or 32 bits */
-#define SDR_CFG_32BITS 0x00000000 /* 32 bits */
-#define SDR_CFG_64BITS 0x01000000 /* 64 bits */
-#define SDR_CFG_MC_V2518_MASK 0x02000000 /* Low VDD2518 (2.5 or 1.8V) */
-#define SDR_CFG_MC_V25 0x00000000 /* 2.5 V */
-#define SDR_CFG_MC_V18 0x02000000 /* 1.8 V */
-#endif /* !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX) */
+#if defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
+#define SDR0_DDRCFG 0x00e0
+#endif /* defined(CONFIG_440EPX) || defined(CONFIG_440GRX) */
#define sdr_ebc 0x0100
#define sdr_uart0 0x0120 /* UART0 Config */
#define sdr_uart1 0x0121 /* UART1 Config */
next prev parent reply other threads:[~2008-11-20 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:03 [U-Boot] [PATCH] Bits reversed in ppc4xx.h Steven A. Falco
2008-11-20 9:56 ` Stefan Roese
2008-11-20 15:31 ` [U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h Steven A. Falco
2008-11-20 18:07 ` Stefan Roese
2008-11-20 19:37 ` Steven A. Falco [this message]
2008-11-21 10:05 ` [U-Boot] [PATCH v2] " Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4925BC95.9070107@harris.com \
--to=sfalco@harris.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.