From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: issues with movnti emulation Date: Fri, 21 Nov 2008 11:04:43 +0000 Message-ID: <4926A3DB.76E4.0078.0@novell.com> References: <4925A0AE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 20.11.08 18:13 >>> >I think the issue is that I did a bad backport to 3.3. The 'case 0xc3' >should be under twobyte_special_insn rather than twobyte_insn, right? The >two separate paths got merged into one in xen-unstable. Oh, indeed - if you mean it the other way around. >Of course this data corruption ought only to happen in cases where we'd >previously have failed an mmio emulation (and hence probably killed the >guest kernel?). Yes, we previously saw emulation failure messages. The guest wasn't killed because of that, however. I have to admit it's been a while since I last looked at mmio emulation - is it eagerly trying to emulate = successive instructions, and return to native execution when emulation failed? If not, I could neither explain why only some data got corrupted here, nor why the guest didn't get killed. Jan