From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] e1000 VLAN offload emulation Date: Fri, 21 Nov 2008 10:25:36 -0600 Message-ID: <4926E100.8040908@codemonkey.ws> References: <1227127052.7652.20.camel@lappy> <4925EEA7.6000804@codemonkey.ws> <1227282085.7652.37.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel , kvm To: Alex Williamson Return-path: Received: from ey-out-2122.google.com ([74.125.78.24]:29455 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756626AbYKUQZn (ORCPT ); Fri, 21 Nov 2008 11:25:43 -0500 Received: by ey-out-2122.google.com with SMTP id 6so418394eyi.37 for ; Fri, 21 Nov 2008 08:25:41 -0800 (PST) In-Reply-To: <1227282085.7652.37.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > On Thu, 2008-11-20 at 17:11 -0600, Anthony Liguori wrote: > >> The patch looks good but I don't like the idea of taking patches against >> kvm-userspace. It suggests that people have only tested in >> kvm-userspace which means it's not guaranteed to work (or even compile) >> in upstream QEMU. Please rebase against QEMU and resubmit. >> > > Hi Anthony, > > Thanks for reviewing. Here's a new one, created and tested against qemu > 5765. Thanks, > Applied. Thanks. Regards, Anthony Liguori From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3YpG-0006tH-3W for qemu-devel@nongnu.org; Fri, 21 Nov 2008 11:25:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3YpE-0006s2-Fm for qemu-devel@nongnu.org; Fri, 21 Nov 2008 11:25:45 -0500 Received: from [199.232.76.173] (port=54751 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3YpE-0006rw-8W for qemu-devel@nongnu.org; Fri, 21 Nov 2008 11:25:44 -0500 Received: from ey-out-1920.google.com ([74.125.78.145]:41056) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L3YpE-0002XX-61 for qemu-devel@nongnu.org; Fri, 21 Nov 2008 11:25:44 -0500 Received: by ey-out-1920.google.com with SMTP id 4so433061eyk.4 for ; Fri, 21 Nov 2008 08:25:41 -0800 (PST) Message-ID: <4926E100.8040908@codemonkey.ws> Date: Fri, 21 Nov 2008 10:25:36 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1227127052.7652.20.camel@lappy> <4925EEA7.6000804@codemonkey.ws> <1227282085.7652.37.camel@lappy> In-Reply-To: <1227282085.7652.37.camel@lappy> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] e1000 VLAN offload emulation Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel , kvm Alex Williamson wrote: > On Thu, 2008-11-20 at 17:11 -0600, Anthony Liguori wrote: > >> The patch looks good but I don't like the idea of taking patches against >> kvm-userspace. It suggests that people have only tested in >> kvm-userspace which means it's not guaranteed to work (or even compile) >> in upstream QEMU. Please rebase against QEMU and resubmit. >> > > Hi Anthony, > > Thanks for reviewing. Here's a new one, created and tested against qemu > 5765. Thanks, > Applied. Thanks. Regards, Anthony Liguori